Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2701403002: [DevTools] Move Popover to shadow DOM. (Closed)

Created:
3 years, 10 months ago by dgozman
Modified:
3 years, 10 months ago
Reviewers:
alph
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move Popover to shadow DOM. BUG=none Review-Url: https://codereview.chromium.org/2701403002 Cr-Commit-Position: refs/heads/master@{#452598} Committed: https://chromium.googlesource.com/chromium/src/+/8a213f053a3a7cbb2b09cc6a51bc26faf3e1da51

Patch Set 1 #

Patch Set 2 : fixed-height #

Total comments: 2

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Popover.js View 1 3 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorStyle.css View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/popover.css View 5 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
dgozman
Could you please take a look?
3 years, 10 months ago (2017-02-20 07:05:15 UTC) #2
alph
lgtm https://codereview.chromium.org/2701403002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/popover.css File third_party/WebKit/Source/devtools/front_end/ui/popover.css (right): https://codereview.chromium.org/2701403002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/popover.css#newcode1 third_party/WebKit/Source/devtools/front_end/ui/popover.css:1: :host { Should we have a copyright header?
3 years, 10 months ago (2017-02-21 21:27:24 UTC) #3
dgozman
https://codereview.chromium.org/2701403002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/popover.css File third_party/WebKit/Source/devtools/front_end/ui/popover.css (right): https://codereview.chromium.org/2701403002/diff/20001/third_party/WebKit/Source/devtools/front_end/ui/popover.css#newcode1 third_party/WebKit/Source/devtools/front_end/ui/popover.css:1: :host { On 2017/02/21 21:27:23, alph wrote: > Should ...
3 years, 10 months ago (2017-02-21 21:36:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701403002/40001
3 years, 10 months ago (2017-02-23 18:30:38 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 20:05:17 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8a213f053a3a7cbb2b09cc6a51bc...

Powered by Google App Engine
This is Rietveld 408576698