Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2701363002: Move code for SelectionEditor in FrameSelection.cpp to SelectionEditor.cpp (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move code for SelectionEditor in FrameSelection.cpp to SelectionEditor.cpp This patch moves implementations of |SelectionEditor| class in "FrameSelection.cpp" to "SelectionEditor.cpp" for improving code health. This patch is follow-up of [1] which keeps |SelectionEditor| code in "FrameSelection.cpp" for ease of reviewing. [1] http://crrev.com/2680943004 Make FrameSelection to hold non-canonicalized positions BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2701363002 Cr-Commit-Position: refs/heads/master@{#451582} Committed: https://chromium.googlesource.com/chromium/src/+/49d3efd26701e0ea83b0d5ca02dbc07f0aa0c53b

Patch Set 1 : 2017-02-20T13:28:50 #

Patch Set 2 : 2017-02-20T16:41:49 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -217 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 3 chunks +0 lines, -217 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionEditor.cpp View 1 1 chunk +193 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
yosin_UTC9
PTAL
3 years, 10 months ago (2017-02-20 04:55:07 UTC) #5
tkent
lgtm
3 years, 10 months ago (2017-02-20 05:55:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701363002/1
3 years, 10 months ago (2017-02-20 06:32:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/368337)
3 years, 10 months ago (2017-02-20 06:38:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701363002/20001
3 years, 10 months ago (2017-02-20 07:43:13 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 09:17:19 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/49d3efd26701e0ea83b0d5ca02db...

Powered by Google App Engine
This is Rietveld 408576698