Make explicit constant for num of CSSPropertyIDs

Make explicit constant for num of CSSPropertyIDs

A handful of locations in the code refer to "lastUnresolvedCSSProperty +
1" as a way of ensuring that a BitVector is big enough to hold all
values for CSSPropertyID. To make the code easier to read, and to
centralize the responsibility for getting the "+ 1" correct, this patch
introduces an explicit numCSSPropertyIDs constant to contain this value.

BUG=458925
Review-Url: https://codereview.chromium.org/2701353002
Cr-Commit-Position: refs/heads/master@{#454811}
Committed: https://chromium.googlesource.com/chromium/src/+/a6b223a87ecb54cdea51f967f273419f282ee9eb

[suzyh_UTC10 (ex-contributor), 2017-02-20 03:52:35]

suzyh@chromium.org changed reviewers:
+ rbyers@chromium.org, sashab@chromium.org

[suzyh_UTC10 (ex-contributor), 2017-02-20 03:57:43]

The CQ bit was checked by suzyh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 03:58:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-02-20 05:30:08]

lgtm

[commit-bot: I haz the power, 2017-02-20 06:03:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 06:03:41]

Dry run: This issue passed the CQ dry run.

[Rick Byers, 2017-02-24 22:17:11]

Sorry I missed this CL!  Nice cleanup, LGTM

[suzyh_UTC10 (ex-contributor), 2017-02-25 00:43:50]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:44:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 00:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:45:56]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[suzyh_UTC10 (ex-contributor), 2017-03-06 00:27:20]

The CQ bit was checked by suzyh@chromium.org

[commit-bot: I haz the power, 2017-03-06 00:27:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 01:55:24]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488760040009260, "parent_rev":
"81fb68953be91ae1d192d22246332cb25a024800", "commit_rev":
"a6b223a87ecb54cdea51f967f273419f282ee9eb"}

[commit-bot: I haz the power, 2017-03-06 01:56:21]

Description was changed from

==========
Make explicit constant for num of CSSPropertyIDs

A handful of locations in the code refer to "lastUnresolvedCSSProperty +
1" as a way of ensuring that a BitVector is big enough to hold all
values for CSSPropertyID. To make the code easier to read, and to
centralize the responsibility for getting the "+ 1" correct, this patch
introduces an explicit numCSSPropertyIDs constant to contain this value.

BUG=458925
==========

to

==========
Make explicit constant for num of CSSPropertyIDs

A handful of locations in the code refer to "lastUnresolvedCSSProperty +
1" as a way of ensuring that a BitVector is big enough to hold all
values for CSSPropertyID. To make the code easier to read, and to
centralize the responsibility for getting the "+ 1" correct, this patch
introduces an explicit numCSSPropertyIDs constant to contain this value.

BUG=458925

Review-Url: https://codereview.chromium.org/2701353002
Cr-Commit-Position: refs/heads/master@{#454811}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6b223a87ecb54cdea51f967f273...
==========

[commit-bot: I haz the power, 2017-03-06 01:56:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a6b223a87ecb54cdea51f967f273...