Removed dated Persistent<>::checkPointer() assert.

Removed dated Persistent<>::checkPointer() assert.

Remove the ASan-only verification that a Persistent<> refers to a heap
object. Static asserts will ensure that Persistent<T> is only instantiated
for GCed types, so this verification adds little extra value.

R=haraken
BUG=

Review-Url: https://codereview.chromium.org/2701273002
Cr-Commit-Position: refs/heads/master@{#451580}
Committed: https://chromium.googlesource.com/chromium/src/+/1721c372d1626d6ed646b9fb1ac03b6e31e08cec

[sof, 2017-02-19 14:56:57]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-19 14:57:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-02-19 15:02:06]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2017-02-19 15:02:06]

please take a look.

This extra check is proving to be a bit constraining when experimenting with
extending the use of checkPointer() over Persistent<>s (
https://codereview.chromium.org/2704673003/ ).

I don't think we really need it any longer though, or am I missing some aspects
of the verification it provides ?

[commit-bot: I haz the power, 2017-02-19 16:33:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-19 16:33:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[haraken, 2017-02-20 00:42:46]

LGTM

[sof, 2017-02-20 06:44:09]

Description was changed from

==========
Removed dated Persistent<>::checkPointer() assert.

Remove the ASan-only verification that a Persistent<> refers to a heap
object. Static asserts will ensure that Persistent<T> is only instantiated
for GCed types, so this verification adds little extra value.

R=
BUG=
==========

to

==========
Removed dated Persistent<>::checkPointer() assert.

Remove the ASan-only verification that a Persistent<> refers to a heap
object. Static asserts will ensure that Persistent<T> is only instantiated
for GCed types, so this verification adds little extra value.

R=haraken
BUG=
==========

[sof, 2017-02-20 06:44:14]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2017-02-20 06:44:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 08:12:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487573054948910, "parent_rev":
"6fbd37145e9b8eb98e1e5b330364db3fd07dd719", "commit_rev":
"1721c372d1626d6ed646b9fb1ac03b6e31e08cec"}

[commit-bot: I haz the power, 2017-02-20 08:13:13]

Description was changed from

==========
Removed dated Persistent<>::checkPointer() assert.

Remove the ASan-only verification that a Persistent<> refers to a heap
object. Static asserts will ensure that Persistent<T> is only instantiated
for GCed types, so this verification adds little extra value.

R=haraken
BUG=
==========

to

==========
Removed dated Persistent<>::checkPointer() assert.

Remove the ASan-only verification that a Persistent<> refers to a heap
object. Static asserts will ensure that Persistent<T> is only instantiated
for GCed types, so this verification adds little extra value.

R=haraken
BUG=

Review-Url: https://codereview.chromium.org/2701273002
Cr-Commit-Position: refs/heads/master@{#451580}
Committed:
https://chromium.googlesource.com/chromium/src/+/1721c372d1626d6ed646b9fb1ac0...
==========

[commit-bot: I haz the power, 2017-02-20 08:13:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1721c372d1626d6ed646b9fb1ac0...