Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2701253003: Selection API: Add diagnostic code for extend() crash (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Selection API: Add diagnostic code for extend() crash Fixing this null pointer deference is easy. However we should understand the root cause. BUG=693578 Review-Url: https://codereview.chromium.org/2701253003 Cr-Commit-Position: refs/heads/master@{#451568} Committed: https://chromium.googlesource.com/chromium/src/+/6ea84c1ad8c14cd91341106e8632bed7c1ddbac4

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
tkent
yoichio@, yosin@, would you review this please?
3 years, 10 months ago (2017-02-20 04:20:28 UTC) #11
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-20 04:27:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701253003/20001
3 years, 10 months ago (2017-02-20 05:51:41 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 05:56:05 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6ea84c1ad8c14cd91341106e8632...

Powered by Google App Engine
This is Rietveld 408576698