|
|
DescriptionSelection API: Add diagnostic code for extend() crash
Fixing this null pointer deference is easy. However we should understand the root
cause.
BUG=693578
Review-Url: https://codereview.chromium.org/2701253003
Cr-Commit-Position: refs/heads/master@{#451568}
Committed: https://chromium.googlesource.com/chromium/src/+/6ea84c1ad8c14cd91341106e8632bed7c1ddbac4
Patch Set 1 : . #
Messages
Total messages: 19 (15 generated)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Selection API: Fix a crash by null oldAnchor. BUG=693578 ========== to ========== Selection API: Add diagnostic code for extend() crash BUG=693578 ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== Selection API: Add diagnostic code for extend() crash BUG=693578 ========== to ========== Selection API: Add diagnostic code for extend() crash Fixing this null pointer deference is easy. However we should understand the root cause. BUG=693578 ==========
tkent@chromium.org changed reviewers: + yoichio@chromium.org, yosin@chromium.org
yoichio@, yosin@, would you review this please?
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487569885551030, "parent_rev": "54210329887cfd683e71722b93a5e05b95f5e12d", "commit_rev": "6ea84c1ad8c14cd91341106e8632bed7c1ddbac4"}
Message was sent while issue was closed.
Description was changed from ========== Selection API: Add diagnostic code for extend() crash Fixing this null pointer deference is easy. However we should understand the root cause. BUG=693578 ========== to ========== Selection API: Add diagnostic code for extend() crash Fixing this null pointer deference is easy. However we should understand the root cause. BUG=693578 Review-Url: https://codereview.chromium.org/2701253003 Cr-Commit-Position: refs/heads/master@{#451568} Committed: https://chromium.googlesource.com/chromium/src/+/6ea84c1ad8c14cd91341106e8632... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6ea84c1ad8c14cd91341106e8632... |