Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2701153002: Pass ScriptState directly to TaskRunnerHelper::get() (Closed)

Created:
3 years, 10 months ago by yuryu
Modified:
3 years, 10 months ago
Reviewers:
haraken, nhiroki, tzik
CC:
chromium-reviews, tzik, dcheng, nhiroki, blink-reviews, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass ScriptState directly to TaskRunnerHelper::get() TaskRunnerHelper::get() has a overload taking ScriptState* instead of ExecutionContext*, so we should let it handle ScriptState* rather than getting ExecutionContext* from ScriptState* at callers. BUG=625927 Review-Url: https://codereview.chromium.org/2701153002 Cr-Commit-Position: refs/heads/master@{#451618} Committed: https://chromium.googlesource.com/chromium/src/+/daa2a25d8775cf2c875984b38e455dd7fd480bc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M third_party/WebKit/Source/core/clipboard/DataTransferItem.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
yuryu
3 years, 10 months ago (2017-02-20 08:25:42 UTC) #7
nhiroki
lgtm
3 years, 10 months ago (2017-02-20 08:29:50 UTC) #9
tzik
lgtm
3 years, 10 months ago (2017-02-20 08:49:34 UTC) #10
yuryu
can you take a look? thanks
3 years, 10 months ago (2017-02-20 09:01:14 UTC) #12
haraken
LGTM
3 years, 10 months ago (2017-02-20 09:33:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701153002/1
3 years, 10 months ago (2017-02-20 11:58:45 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 13:51:51 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/daa2a25d8775cf2c875984b38e45...

Powered by Google App Engine
This is Rietveld 408576698