Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2701053002: Revert of Add net-log entries when HttpStream jobs are forced to wait, and when they're delayed and resumed. (Closed)

Created:
3 years, 10 months ago by Zhongyi Shi
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert of Add net-log entries when HttpStream jobs are forced to wait, and when they're delayed and resumed. (patchset #1 id:1 of https://codereview.chromium.org/2699833007/ ) Reason for revert: Revert this issue as it blocks the Beta build( dependent on https://chromium.googlesource.com/chromium/src/+/9255195315efa671012f0bd0da1afe685d70b2f6). Will fix the cl and re-merge. Original issue's description: > Add net-log entries when HttpStream jobs are forced to wait, and when they're delayed and resumed. > > BUG=691688 > > Review-Url: https://codereview.chromium.org/2699433003 > Cr-Commit-Position: refs/heads/master@{#450608} > (cherry picked from commit d27cf4ed111ab7f3bdab607fe48e4446d6cf15ca) > > Review-Url: https://codereview.chromium.org/2699833007 . > Cr-Commit-Position: refs/branch-heads/2987@{#579} > Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} > Committed: https://chromium.googlesource.com/chromium/src/+/e5aaefbb2c1f86245d1130c7c645d193555f49f8 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691688 Review-Url: https://codereview.chromium.org/2701053002 Cr-Commit-Position: refs/branch-heads/2987@{#582} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b0fbd102ec86c933c893ee3e7d45675f53e4ebe3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -56 lines) Patch
M net/http/http_stream_factory_impl_job.cc View 1 chunk +1 line, -5 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller.cc View 3 chunks +37 lines, -30 lines 0 comments Download
M net/log/net_log_event_type_list.h View 2 chunks +3 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (4 generated)
Zhongyi Shi
3 years, 10 months ago (2017-02-17 21:44:35 UTC) #2
Created Revert of Add net-log entries when HttpStream jobs are forced to wait,
and when they're delayed and resumed.

Powered by Google App Engine
This is Rietveld 408576698