Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 2701023003: cros: Move call js prefix out of ctor. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, pam+watch_chromium.org, alemate+watch_chromium.org, achuith+watch_chromium.org, dcheng, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Move call js prefix out of ctor. BUG=672142 Review-Url: https://codereview.chromium.org/2701023003 Cr-Commit-Position: refs/heads/master@{#452152} Committed: https://chromium.googlesource.com/chromium/src/+/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -109 lines) Patch
M chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/base_screen_handler.h View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (15 generated)
jdufault
alemate@ PTAL
3 years, 10 months ago (2017-02-21 19:06:24 UTC) #9
jdufault
On 2017/02/21 19:06:24, jdufault wrote: > alemate@ PTAL * There should be no functional change.
3 years, 10 months ago (2017-02-21 19:06:46 UTC) #10
Alexander Alekseev
lgtm
3 years, 10 months ago (2017-02-22 00:40:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701023003/1
3 years, 10 months ago (2017-02-22 00:43:27 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-22 02:46:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2701023003/1
3 years, 10 months ago (2017-02-22 18:53:46 UTC) #19
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 19:06:04 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/41140d63ffc66fc6b93b6a3012b5...

Powered by Google App Engine
This is Rietveld 408576698