Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 2700973003: Print additional information on failed beCloseToArray tests (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Print additional information on failed beCloseToArray tests When a beCloseToArray test fails, print out the detailed information for the entries with the max absolute error and max relative error. We also refactored some common printing and threshold code into their own functions to ensure the format is consistent. Finally, also print out how many failures were not printed in the list. BUG=693246 TEST=audit-failures.html Review-Url: https://codereview.chromium.org/2700973003 Cr-Commit-Position: refs/heads/master@{#451815} Committed: https://chromium.googlesource.com/chromium/src/+/29590e9db1219d95b6713ee229a758449bc62c73

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/resources/audit.js View 1 3 chunks +57 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures.html View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-failures-expected.txt View 3 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-18 00:05:05 UTC) #2
hongchan
lgtm with a nit https://codereview.chromium.org/2700973003/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/audit.js File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2700973003/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/audit.js#newcode83 third_party/WebKit/LayoutTests/webaudio/resources/audit.js:83: // Return a string suitable ...
3 years, 10 months ago (2017-02-21 17:05:52 UTC) #3
Raymond Toy
https://codereview.chromium.org/2700973003/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/audit.js File third_party/WebKit/LayoutTests/webaudio/resources/audit.js (right): https://codereview.chromium.org/2700973003/diff/1/third_party/WebKit/LayoutTests/webaudio/resources/audit.js#newcode83 third_party/WebKit/LayoutTests/webaudio/resources/audit.js:83: // Return a string suitable for printing one failed ...
3 years, 10 months ago (2017-02-21 17:43:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700973003/20001
3 years, 10 months ago (2017-02-21 17:45:30 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 19:13:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/29590e9db1219d95b6713ee229a7...

Powered by Google App Engine
This is Rietveld 408576698