Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2700933002: Updates the IME state when necessary when switching top-level windows. (Closed)

Created:
3 years, 10 months ago by Shu Chen
Modified:
3 years, 10 months ago
Reviewers:
lshang, James Su, yukawa
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updates the IME state when necessary when switching top-level windows. BUG=679564, 680524 Review-Url: https://codereview.chromium.org/2700933002 Cr-Commit-Position: refs/heads/master@{#451460} Committed: https://chromium.googlesource.com/chromium/src/+/17c78241a37810aff596974cfdec60b01bc0f4c5

Patch Set 1 #

Patch Set 2 : Updates the IME state when necessary when switching top-level windows. #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M ui/base/ime/input_method_win.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M ui/base/ime/input_method_win.cc View 1 2 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (13 generated)
Shu Chen
Guys, can you please review this cl? Thanks!
3 years, 10 months ago (2017-02-17 07:18:03 UTC) #2
yukawa
lgtm
3 years, 10 months ago (2017-02-17 17:52:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700933002/40001
3 years, 10 months ago (2017-02-18 02:23:16 UTC) #11
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-18 02:23:28 UTC) #13
Shu Chen
I'm confused. yukawa@, you're not a full committer now?
3 years, 10 months ago (2017-02-18 02:25:24 UTC) #14
yukawa
On 2017/02/18 02:25:24, Shu Chen wrote: > I'm confused. yukawa@, you're not a full committer ...
3 years, 10 months ago (2017-02-18 02:29:47 UTC) #15
Shu Chen
+lshang@ for rubber stamp.
3 years, 10 months ago (2017-02-18 11:42:39 UTC) #17
lshang
lgtm
3 years, 10 months ago (2017-02-18 12:58:10 UTC) #18
lshang
lgtm
3 years, 10 months ago (2017-02-18 12:58:14 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700933002/40001
3 years, 10 months ago (2017-02-18 13:00:02 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 13:54:09 UTC) #24
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/17c78241a37810aff596974cfdec...

Powered by Google App Engine
This is Rietveld 408576698