Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 2700823002: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. (Closed)

Created:
3 years, 10 months ago by zakerinasab
Modified:
3 years, 9 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. This change replaces js-test.js assertions with testharness.js assertions. The expectation files are removed as they are not needed anymore. To simplify review and landing, each change corrects at most 10 tests. BUG=639732 Review-Url: https://codereview.chromium.org/2700823002 Cr-Commit-Position: refs/heads/master@{#453237} Committed: https://chromium.googlesource.com/chromium/src/+/4962b8341ddb7689e2e7b15d9754f7224ed979bf

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -503 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/change-context.html View 1 chunk +17 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/change-context-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed.html View 1 chunk +36 lines, -36 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-invisible-crash.html View 1 chunk +15 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-invisible-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-on-event.html View 2 chunks +17 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-on-event-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-scrolls-horiz.html View 1 2 chunks +47 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-scrolls-horiz-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-with-path2d.html View 1 chunk +42 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-with-path2d-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/drawImage-with-bad-canvas.html View 2 chunks +7 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/drawImage-with-bad-canvas-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/drawImage-with-broken-image.html View 1 chunk +29 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/drawImage-with-broken-image-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/drawImage-with-negative-source-destination.html View 1 chunk +34 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/drawImage-with-negative-source-destination.js View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/drawImage-with-negative-source-destination-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/drawImage-with-valid-image.html View 1 chunk +108 lines, -110 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/drawImage-with-valid-image-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Justin Novosad
lgtm + nit https://codereview.chromium.org/2700823002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-scrolls-horiz.html File third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-scrolls-horiz.html (right): https://codereview.chromium.org/2700823002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-scrolls-horiz.html#newcode17 third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-scrolls-horiz.html:17: var canvas = document.getElementById("canvas"); indent
3 years, 10 months ago (2017-02-24 21:23:06 UTC) #2
zakerinasab
Comments addressed. Landing. https://codereview.chromium.org/2700823002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-scrolls-horiz.html File third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-scrolls-horiz.html (right): https://codereview.chromium.org/2700823002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-scrolls-horiz.html#newcode17 third_party/WebKit/LayoutTests/fast/canvas/draw-focus-if-needed-scrolls-horiz.html:17: var canvas = document.getElementById("canvas"); On 2017/02/24 ...
3 years, 9 months ago (2017-02-27 15:36:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700823002/20001
3 years, 9 months ago (2017-02-27 15:37:08 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 17:02:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4962b8341ddb7689e2e7b15d9754...

Powered by Google App Engine
This is Rietveld 408576698