Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 2700783002: s/\bArc\b/ARC/g for ARC related code. (Closed)

Created:
3 years, 10 months ago by hidehiko
Modified:
3 years, 10 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, extensions-reviews_chromium.org, alemate+watch_chromium.org, sadrul, yusukes+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, tfarina, hidehiko+watch_chromium.org, achuith+watch_chromium.org, khmel+watch_chromium.org, michaelpg+watch-md-ui_chromium.org, sync-reviews_chromium.org, lhchavez+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

s/\bArc\b/ARC/g for ARC related code. This CL replaces "Arc" by "ARC" for standardization, mostly for comments and logs. Non-targets are; - Resources (E.g. .grd, .grdp files) - UMA names. - Special HTTP status code name. - Several embedded string, which we need to use Arc to follow their rule. TBR=oshima@chromium.org, xiyuan@chromium.org, chrisha@chromium.org, isherman@chromium.org, stevenjb@chromium.org, maxbogue@chromium.org, skuhne@chromium.org, benwells@chromium.org, msw@chromium.org, steel@chromium.org, dcheng@chromium.org BUG=None TEST=Ran bots. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2700783002 Cr-Commit-Position: refs/heads/master@{#451267} Committed: https://chromium.googlesource.com/chromium/src/+/5f6e56e59eb16be722d9424dafa03d19a2aa6697

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Address ARC++ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -129 lines) Patch
M ash/common/system/chromeos/audio/tray_audio.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/public/cpp/shelf_types.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/arc/arc_kiosk_app_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_auth_notification.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_optin_uma.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_session_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/optin/arc_optin_preference_handler_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/gfx_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_manager_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/arc_kiosk_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/dm_token_storage.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/perf/perf_provider_chromeos.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/android_apps_page/android_apps_browser_proxy.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/migration_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_context_menu_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_dialog.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_launcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_model_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_default_app_list.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_default_app_list.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_syncable_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_shelf_id.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_shelf_id.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/arc_launcher_context_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 17 chunks +22 lines, -22 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_controller_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/extensions/app_launch_params.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/arc_app_dialog_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/arc_app_dialog_view_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/url_constants.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/arc_features.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/arc/common/process.mojom View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/sync/base/model_type.h View 1 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/app_runtime.idl View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (13 generated)
hidehiko
I'm very sure this is a boring CL... but, I was asked to replace existing ...
3 years, 10 months ago (2017-02-16 13:17:45 UTC) #5
Luis Héctor Chávez
thank you very much for doing this :D I pre-emptively added an entry in the ...
3 years, 10 months ago (2017-02-16 18:20:04 UTC) #8
hidehiko
R+=OWNERs and TBR=OWNERs. OWNERs, please let me submit with TBR under Luis's LGTM following the ...
3 years, 10 months ago (2017-02-17 06:06:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700783002/40001
3 years, 10 months ago (2017-02-17 06:07:48 UTC) #15
dcheng
rs lgtm for mojo
3 years, 10 months ago (2017-02-17 07:34:12 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/5f6e56e59eb16be722d9424dafa03d19a2aa6697
3 years, 10 months ago (2017-02-17 08:16:54 UTC) #19
msw
3 years, 10 months ago (2017-02-17 18:37:16 UTC) #20
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698