Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2700773003: [Offline Pages] Download UI: Remove all observers when clearing cache. (Closed)

Created:
3 years, 10 months ago by dewittj
Modified:
3 years, 10 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Download UI: Remove all observers when clearing cache. BUG=692609 R=dimich@chromium.org Review-Url: https://codereview.chromium.org/2700773003 Cr-Commit-Position: refs/heads/master@{#451101} Committed: https://chromium.googlesource.com/chromium/src/+/552815e8a485fe0346a55631ab1f9b72f0551fd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M components/offline_pages/core/downloads/download_ui_adapter.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/offline_pages/core/downloads/download_ui_adapter_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dewittj
ptal, thanks
3 years, 10 months ago (2017-02-16 19:41:33 UTC) #2
Dmitry Titov
LGTM, thanks!
3 years, 10 months ago (2017-02-16 19:42:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700773003/1
3 years, 10 months ago (2017-02-16 19:44:31 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 21:24:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/552815e8a485fe0346a55631ab1f...

Powered by Google App Engine
This is Rietveld 408576698