Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2700753002: Replace ExecutionContextTask with WTF::Closure in StorageErrorCallback (Closed)

Created:
3 years, 10 months ago by yuryu
Modified:
3 years, 10 months ago
Reviewers:
haraken, nhiroki, tzik
CC:
chromium-reviews, blink-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ExecutionContextTask with WTF::Closure in StorageErrorCallback ExecutionContextTask is deprecated and will be replaced with WTF::Closure. This patch replaces ExecutionContextTask and ExecutionContext::postTask in StorageErrorCallback to WTF::Closure and WebTaskRunner::postTask respectively. BUG=625927 Review-Url: https://codereview.chromium.org/2700753002 Cr-Commit-Position: refs/heads/master@{#451230} Committed: https://chromium.googlesource.com/chromium/src/+/6b2bb377f6425e4504ee8b2265ffe9bda97e191d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M third_party/WebKit/Source/modules/quota/DeprecatedStorageInfo.cpp View 3 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/DeprecatedStorageQuota.cpp View 3 chunks +13 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageErrorCallback.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageErrorCallback.cpp View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
yuryu
Hi, can you take a look?
3 years, 10 months ago (2017-02-16 15:02:40 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-02-16 15:32:25 UTC) #7
nhiroki
lgtm
3 years, 10 months ago (2017-02-17 04:33:37 UTC) #8
tzik
lgtm
3 years, 10 months ago (2017-02-17 04:36:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700753002/1
3 years, 10 months ago (2017-02-17 05:06:49 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 05:19:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6b2bb377f6425e4504ee8b2265ff...

Powered by Google App Engine
This is Rietveld 408576698