Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2700713004:
gpu: Only init ANGLE Platform on ANGLE. (Closed)
|
Created:
3 years, 10 months ago by Jamie Madill Modified:
3 years, 10 months ago CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiongpu: Only init ANGLE Platform on ANGLE.
Instead of always trying to init the ANGLE platform, require at
least one of the ANGLE display extensions to be present. This gives
a pretty good idea if we're running on ANGLE EGL in the first place.
BUG=692920
R=jbauman@chromium.org,kbr@chromium.org
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2700713004
Cr-Commit-Position: refs/heads/master@{#451132}
Committed: https://chromium.googlesource.com/chromium/src/+/5959d07ba1e77b02c3c67698243fdf0f3ee186fc
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
The CQ bit was checked by jmadill@chromium.org to run a CQ dry run
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
lgtm
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/02/16 22:01:19, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Hum, been stuck on chromium_presubmit for 40 minutes. re-cqing.
The CQ bit was unchecked by jmadill@chromium.org
The CQ bit was checked by jmadill@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== gpu: Only init ANGLE Platform on ANGLE. Instead of always trying to init the ANGLE platform, require at least one of the ANGLE display extensions to be present. This gives a pretty good idea if we're running on ANGLE EGL in the first place. BUG=692920 R=jbauman@chromium.org,kbr@chromium.org ========== to ========== gpu: Only init ANGLE Platform on ANGLE. Instead of always trying to init the ANGLE platform, require at least one of the ANGLE display extensions to be present. This gives a pretty good idea if we're running on ANGLE EGL in the first place. BUG=692920 R=jbauman@chromium.org,kbr@chromium.org NOPRESUBMIT=true ==========
The CQ bit was unchecked by jmadill@chromium.org
skipping presubmit since it passed all bots.
The CQ bit was checked by jmadill@chromium.org
created crbug.com/693241
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487285282870320, "parent_rev":
"5b9f76d231ed64f920257d9d97a507bc9752a94a", "commit_rev":
"5959d07ba1e77b02c3c67698243fdf0f3ee186fc"}
Message was sent while issue was closed.
Description was changed from ========== gpu: Only init ANGLE Platform on ANGLE. Instead of always trying to init the ANGLE platform, require at least one of the ANGLE display extensions to be present. This gives a pretty good idea if we're running on ANGLE EGL in the first place. BUG=692920 R=jbauman@chromium.org,kbr@chromium.org NOPRESUBMIT=true ========== to ========== gpu: Only init ANGLE Platform on ANGLE. Instead of always trying to init the ANGLE platform, require at least one of the ANGLE display extensions to be present. This gives a pretty good idea if we're running on ANGLE EGL in the first place. BUG=692920 R=jbauman@chromium.org,kbr@chromium.org NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2700713004 Cr-Commit-Position: refs/heads/master@{#451132} Committed: https://chromium.googlesource.com/chromium/src/+/5959d07ba1e77b02c3c67698243f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5959d07ba1e77b02c3c67698243f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
