Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2700713002: Assume the 1st USB device configuration has been selected on Android. (Closed)

Created:
3 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
juncai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Assume the 1st USB device configuration has been selected on Android. Linux will almost always select the first configuration and this avoids apps issuing a SetConfiguration request which may fail if the system thinks the device is busy. A better option is to look into whether I can read the currently selected configuration out of sysfs on Android but that is a much larger patch so this is a good stop-gap measure. BUG=692861 Review-Url: https://codereview.chromium.org/2700713002 Cr-Commit-Position: refs/heads/master@{#451054} Committed: https://chromium.googlesource.com/chromium/src/+/3ab86ccb569cff38b362457b7a12762dc9cbab82

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M device/usb/usb_device_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 10 months ago (2017-02-16 01:19:41 UTC) #2
juncai
LGTM.
3 years, 10 months ago (2017-02-16 19:08:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700713002/1
3 years, 10 months ago (2017-02-16 19:23:05 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 19:39:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ab86ccb569cff38b362457b7a12...

Powered by Google App Engine
This is Rietveld 408576698