|
|
Chromium Code Reviews
Description[MD Bookmarks] Expose chrome.bookmarks.import/export to MD Bookmarks
BUG=658980, 692848
Review-Url: https://codereview.chromium.org/2700693002
Cr-Commit-Position: refs/heads/master@{#451974}
Committed: https://chromium.googlesource.com/chromium/src/+/78cb58e46b5b386904878be7847399b14f0e4d63
Patch Set 1 #
Messages
Total messages: 17 (7 generated)
Description was changed from ========== [MD Bookmarks] Expose chrome.bookmarks.import/export to MD Bookmarks BUG=658980, 692848 R=mkearney@chromium.org, tsergeant@chromium.org ========== to ========== [MD Bookmarks] Expose chrome.bookmarks.import/export to MD Bookmarks BUG=658980, 692848 ==========
loorongjie@gmail.com changed reviewers: + rdevlin.cronin@chromium.org - mkearney@chromium.org
Updated reviewers, hope I am calling the right persons this time.
lgtm
Ah, sorry, this slipped my mind As discussed over email, lgtm
Ping?
You've got all the code reviews you need, so I'll click the 'Commit' checkbox for you. For future reference, you should be able to do that yourself once the relevant people have said 'l-g-t-m' =)
The CQ bit was checked by tsergeant@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by loorongjie@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487753726218890, "parent_rev":
"ec28bf711c7ebeceed2271b2e7836d45b24704d6", "commit_rev":
"78cb58e46b5b386904878be7847399b14f0e4d63"}
Message was sent while issue was closed.
Description was changed from ========== [MD Bookmarks] Expose chrome.bookmarks.import/export to MD Bookmarks BUG=658980, 692848 ========== to ========== [MD Bookmarks] Expose chrome.bookmarks.import/export to MD Bookmarks BUG=658980, 692848 Review-Url: https://codereview.chromium.org/2700693002 Cr-Commit-Position: refs/heads/master@{#451974} Committed: https://chromium.googlesource.com/chromium/src/+/78cb58e46b5b386904878be78473... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/78cb58e46b5b386904878be78473... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
