third_party/WebKit/LayoutTests/external/wpt/selection/extend.js - Issue 2700673005: selection: Do not run invalid sub-tests with unselectable Range.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/selection/extend.js

Issue 2700673005: selection: Do not run invalid sub-tests with unselectable Range. (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/LayoutTests/external/wpt/selection/extend.js

diff --git a/third_party/WebKit/LayoutTests/external/wpt/selection/extend.js b/third_party/WebKit/LayoutTests/external/wpt/selection/extend.js

index 6a2307e5e5396f5b67e5a5b2a6d6685a903ed257..a3be628d6c8d37ce5f646656b3fc6ba7b3808cb9 100644

--- a/third_party/WebKit/LayoutTests/external/wpt/selection/extend.js

+++ b/third_party/WebKit/LayoutTests/external/wpt/selection/extend.js

@@ -23,6 +23,9 @@ function testExtendSubSet(startIndex, optionalEndIndex) {

// selections only once.

for (var i = startIndex; i < endIndex; i++) {

var endpoints = eval(testRanges[i]);

+ // We can't test extend() with unselectable endpoints.

+ if (!isSelectableNode(endpoints[0]) || !isSelectableNode(endpoints[2]))

+ continue;

for (var j = 0; j < testPoints.length; j++) {

if (endpoints[0] == endpoints[2]

&& endpoints[1] == endpoints[3]) {