Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2700673005: selection: Do not run invalid sub-tests with unselectable Range. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

selection: Do not run invalid sub-tests with unselectable endpoints. * addRange.js: It assumes any Range can be added to Selection. However the latest draft defines that addRange() rejects Ranges in a root different from Selection's document. Some tests after addRange() with such Ranges were invalid. https://w3c.github.io/selection-api/#dom-selection-addrange > The method must set the context object's range to range by a > strong reference (not by making a copy) if the root ([DOM4]) of > the range's boundary points are the document associated with > context object. Otherwise, this method must do nothing. * exntend.js extend() requires rangeCount>=1. setSelectionForwards() and setSelectionBackwards() are assumed to ensure it. However, these function can't set specified endpoints if they are in roots different from Selection's document. We should skip such endpoints. This CL removes 25,200 invalid tests. BUG=683066 Review-Url: https://codereview.chromium.org/2700673005 Cr-Commit-Position: refs/heads/master@{#451545} Committed: https://chromium.googlesource.com/chromium/src/+/329ba0e15e8853ef13e600776f1b3da4f30b0235

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2146 lines, -33198 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange.js View 1 2 chunks +19 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-00-expected.txt View 1 21 chunks +218 lines, -938 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-04-expected.txt View 1 21 chunks +218 lines, -938 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-08-expected.txt View 1 1 chunk +0 lines, -2998 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-12-expected.txt View 1 11 chunks +226 lines, -1880 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-16-expected.txt View 1 16 chunks +222 lines, -1409 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-20-expected.txt View 1 11 chunks +226 lines, -1880 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-24-expected.txt View 1 11 chunks +342 lines, -1996 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-28-expected.txt View 1 21 chunks +218 lines, -938 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-32-expected.txt View 1 16 chunks +222 lines, -1409 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/addRange-36-expected.txt View 1 21 chunks +218 lines, -938 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-40-expected.txt View 1 1 chunk +0 lines, -2824 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-44-expected.txt View 1 1 chunk +0 lines, -2882 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-48-expected.txt View 1 1 chunk +0 lines, -2940 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-52-expected.txt View 1 1 chunk +0 lines, -2882 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/selection/addRange-56-expected.txt View 1 1 chunk +0 lines, -1414 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/common.js View 1 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/extend.js View 1 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/extend-00-expected.txt View 1 2 chunks +1 line, -1233 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/extend-20-expected.txt View 1 3 chunks +1 line, -969 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/selection/extend-40-expected.txt View 1 2 chunks +1 line, -2729 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
tkent
yoichio@, yosin@, would you review this please?
3 years, 10 months ago (2017-02-17 16:29:16 UTC) #8
yoichio
lgtm
3 years, 10 months ago (2017-02-20 01:58:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700673005/10001
3 years, 10 months ago (2017-02-20 02:17:18 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 02:25:06 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:10001) as
https://chromium.googlesource.com/chromium/src/+/329ba0e15e8853ef13e600776f1b...

Powered by Google App Engine
This is Rietveld 408576698