third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h - Issue 2700663002: Adds keyboard functionality for videos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

Issue 2700663002: Adds keyboard functionality for videos. (Closed)

Patch Set: Addresses mlamouri's #22, adds tests. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/media/MediaControls.h ('K') | « third_party/WebKit/Source/core/html/shadow/MediaControlElements.h ('k') | third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

diff --git a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

index 629a236a9c63e7707551e80dc22267a7a9b6f432..7d3d2857cb7484e23f8b44e9c07c40618dbbfff6 100644

--- a/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

+++ b/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h

@@ -201,6 +201,7 @@ class MODULES_EXPORT MediaControlsImpl final : public HTMLDivElement,

void OnEnteredFullscreen();

void OnExitedFullscreen();

void OnPanelKeypress();

+ void OnMediaKeyboardEvent(Event* event) { DefaultEventHandler(event); }

// Media control elements.

Member<MediaControlOverlayEnclosureElement> overlay_enclosure_;