third_party/WebKit/Source/core/html/media/MediaControls.h - Issue 2700663002: Adds keyboard functionality for videos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/media/MediaControls.h

Issue 2700663002: Adds keyboard functionality for videos. (Closed)

Patch Set: Addresses mlamouri's #22, adds tests. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/media/MediaControls.h

diff --git a/third_party/WebKit/Source/core/html/media/MediaControls.h b/third_party/WebKit/Source/core/html/media/MediaControls.h

index 4277609080a6860a961532af574b77a380e1ef65..cafd4c70c28a0314bbdcc19e7c3693eba0f7a26b 100644

--- a/third_party/WebKit/Source/core/html/media/MediaControls.h

+++ b/third_party/WebKit/Source/core/html/media/MediaControls.h

@@ -12,6 +12,7 @@

namespace blink {

class Document;

+class Event;

class HTMLMediaElement;

class LayoutObject;

class MediaControlPanelElement;

@@ -85,6 +86,7 @@ class CORE_EXPORT MediaControls : public GarbageCollectedMixin {

virtual void ToggleOverflowMenu() = 0;

virtual bool OverflowMenuVisible() = 0;

virtual void OnMediaControlsEnabledChange() = 0;

+ virtual void OnMediaKeyboardEvent(Event*) = 0;

mlamouri (slow - plz ping) 2017/04/13 14:28:21 I don't think you need this.

CJ 2017/04/14 21:56:45 Done.

DECLARE_VIRTUAL_TRACE();