Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: third_party/WebKit/Source/core/html/media/MediaControls.h

Issue 2700663002: Adds keyboard functionality for videos. (Closed)
Patch Set: Addresses mlamouri's #22, adds tests. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MediaControls_h 5 #ifndef MediaControls_h
6 #define MediaControls_h 6 #define MediaControls_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "platform/heap/Handle.h" 9 #include "platform/heap/Handle.h"
10 #include "platform/heap/Visitor.h" 10 #include "platform/heap/Visitor.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 class Document; 14 class Document;
15 class Event;
15 class HTMLMediaElement; 16 class HTMLMediaElement;
16 class LayoutObject; 17 class LayoutObject;
17 class MediaControlPanelElement; 18 class MediaControlPanelElement;
18 class ShadowRoot; 19 class ShadowRoot;
19 20
20 // MediaControls is an interface to abstract the HTMLMediaElement controls. The 21 // MediaControls is an interface to abstract the HTMLMediaElement controls. The
21 // implementation will be used using a Factory (see below). 22 // implementation will be used using a Factory (see below).
22 class CORE_EXPORT MediaControls : public GarbageCollectedMixin { 23 class CORE_EXPORT MediaControls : public GarbageCollectedMixin {
23 public: 24 public:
24 // Factory class that HTMLMediaElement uses to create the MediaControls 25 // Factory class that HTMLMediaElement uses to create the MediaControls
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 virtual void EndScrubbing() = 0; 79 virtual void EndScrubbing() = 0;
79 virtual void UpdateCurrentTimeDisplay() = 0; 80 virtual void UpdateCurrentTimeDisplay() = 0;
80 virtual void ToggleTextTrackList() = 0; 81 virtual void ToggleTextTrackList() = 0;
81 virtual void ShowTextTrackAtIndex(unsigned) = 0; 82 virtual void ShowTextTrackAtIndex(unsigned) = 0;
82 virtual void DisableShowingTextTracks() = 0; 83 virtual void DisableShowingTextTracks() = 0;
83 virtual void EnterFullscreen() = 0; 84 virtual void EnterFullscreen() = 0;
84 virtual void ExitFullscreen() = 0; 85 virtual void ExitFullscreen() = 0;
85 virtual void ToggleOverflowMenu() = 0; 86 virtual void ToggleOverflowMenu() = 0;
86 virtual bool OverflowMenuVisible() = 0; 87 virtual bool OverflowMenuVisible() = 0;
87 virtual void OnMediaControlsEnabledChange() = 0; 88 virtual void OnMediaControlsEnabledChange() = 0;
89 virtual void OnMediaKeyboardEvent(Event*) = 0;
mlamouri (slow - plz ping) 2017/04/13 14:28:21 I don't think you need this.
CJ 2017/04/14 21:56:45 Done.
88 90
89 DECLARE_VIRTUAL_TRACE(); 91 DECLARE_VIRTUAL_TRACE();
90 92
91 private: 93 private:
92 Member<HTMLMediaElement> media_element_; 94 Member<HTMLMediaElement> media_element_;
93 }; 95 };
94 96
95 } // namespace blink 97 } // namespace blink
96 98
97 #endif // MediaControls_h 99 #endif // MediaControls_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698