Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 2700663002: Adds keyboard functionality for videos. (Closed)
Patch Set: Clean up. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 refreshCastButtonVisibility(); 112 refreshCastButtonVisibility();
113 } 113 }
114 114
115 // TODO(mlamouri): this method is needed in order to notify the controls that 115 // TODO(mlamouri): this method is needed in order to notify the controls that
116 // the `mediaControlsEnabled` setting has changed. 116 // the `mediaControlsEnabled` setting has changed.
117 void onMediaControlsEnabledChange() { 117 void onMediaControlsEnabledChange() {
118 // There is no update because only the overlay is expected to change. 118 // There is no update because only the overlay is expected to change.
119 refreshCastButtonVisibilityWithoutUpdate(); 119 refreshCastButtonVisibilityWithoutUpdate();
120 } 120 }
121 121
122 void onMediaKeyboardEvent(Event* event) { defaultEventHandler(event); }
mlamouri (slow - plz ping) 2017/03/27 13:02:12 Can you move this in the block that starts with th
CJ 2017/04/08 00:31:27 Done.
123
122 DECLARE_VIRTUAL_TRACE(); 124 DECLARE_VIRTUAL_TRACE();
123 125
124 private: 126 private:
125 friend class MediaControlsMediaEventListener; 127 friend class MediaControlsMediaEventListener;
126 friend class MediaControlsOrientationLockDelegateTest; 128 friend class MediaControlsOrientationLockDelegateTest;
127 friend class MediaControlsTest; 129 friend class MediaControlsTest;
128 130
129 void invalidate(Element*); 131 void invalidate(Element*);
130 132
131 // Need to be members of MediaControls for private member access. 133 // Need to be members of MediaControls for private member access.
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 IntSize m_size; 235 IntSize m_size;
234 236
235 bool m_keepShowingUntilTimerFires : 1; 237 bool m_keepShowingUntilTimerFires : 1;
236 }; 238 };
237 239
238 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls()); 240 DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls());
239 241
240 } // namespace blink 242 } // namespace blink
241 243
242 #endif 244 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698