Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h

Issue 2700663002: Adds keyboard functionality for videos. (Closed)
Patch Set: Clean up. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 public: 113 public:
114 static MediaControlPlayButtonElement* create(MediaControls&); 114 static MediaControlPlayButtonElement* create(MediaControls&);
115 115
116 bool willRespondToMouseClickEvents() override { return true; } 116 bool willRespondToMouseClickEvents() override { return true; }
117 void updateDisplayType() override; 117 void updateDisplayType() override;
118 118
119 WebLocalizedString::Name getOverflowStringName() override; 119 WebLocalizedString::Name getOverflowStringName() override;
120 120
121 bool hasOverflowButton() override { return true; } 121 bool hasOverflowButton() override { return true; }
122 122
123 void onMediaKeyboardEvent(Event* event) { defaultEventHandler(event); }
124
123 private: 125 private:
124 explicit MediaControlPlayButtonElement(MediaControls&); 126 explicit MediaControlPlayButtonElement(MediaControls&);
125 127
126 void defaultEventHandler(Event*) override; 128 void defaultEventHandler(Event*) override;
127 }; 129 };
128 130
129 // ---------------------------- 131 // ----------------------------
130 132
131 class MediaControlOverlayPlayButtonElement final 133 class MediaControlOverlayPlayButtonElement final
132 : public MediaControlInputElement { 134 : public MediaControlInputElement {
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
266 public: 268 public:
267 static MediaControlTimelineElement* create(MediaControls&); 269 static MediaControlTimelineElement* create(MediaControls&);
268 270
269 bool willRespondToMouseClickEvents() override; 271 bool willRespondToMouseClickEvents() override;
270 272
271 // FIXME: An "earliest possible position" will be needed once that concept 273 // FIXME: An "earliest possible position" will be needed once that concept
272 // is supported by HTMLMediaElement, see https://crbug.com/137275 274 // is supported by HTMLMediaElement, see https://crbug.com/137275
273 void setPosition(double); 275 void setPosition(double);
274 void setDuration(double); 276 void setDuration(double);
275 277
278 void onMediaKeyboardEvent(Event* event) { defaultEventHandler(event); }
279
276 private: 280 private:
277 explicit MediaControlTimelineElement(MediaControls&); 281 explicit MediaControlTimelineElement(MediaControls&);
278 282
279 void defaultEventHandler(Event*) override; 283 void defaultEventHandler(Event*) override;
280 bool keepEventInNode(Event*) override; 284 bool keepEventInNode(Event*) override;
281 }; 285 };
282 286
283 // ---------------------------- 287 // ----------------------------
284 288
285 class MediaControlFullscreenButtonElement final 289 class MediaControlFullscreenButtonElement final
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 // ---------------------------- 351 // ----------------------------
348 352
349 class MediaControlVolumeSliderElement final : public MediaControlInputElement { 353 class MediaControlVolumeSliderElement final : public MediaControlInputElement {
350 public: 354 public:
351 static MediaControlVolumeSliderElement* create(MediaControls&); 355 static MediaControlVolumeSliderElement* create(MediaControls&);
352 356
353 bool willRespondToMouseMoveEvents() override; 357 bool willRespondToMouseMoveEvents() override;
354 bool willRespondToMouseClickEvents() override; 358 bool willRespondToMouseClickEvents() override;
355 void setVolume(double); 359 void setVolume(double);
356 360
361 void onMediaKeyboardEvent(Event* event) { defaultEventHandler(event); }
362
357 private: 363 private:
358 explicit MediaControlVolumeSliderElement(MediaControls&); 364 explicit MediaControlVolumeSliderElement(MediaControls&);
359 365
360 void defaultEventHandler(Event*) override; 366 void defaultEventHandler(Event*) override;
361 bool keepEventInNode(Event*) override; 367 bool keepEventInNode(Event*) override;
362 }; 368 };
363 369
364 // ---------------------------- 370 // ----------------------------
365 371
366 class MediaControlTimeRemainingDisplayElement final 372 class MediaControlTimeRemainingDisplayElement final
(...skipping 12 matching lines...) Expand all
379 public: 385 public:
380 static MediaControlCurrentTimeDisplayElement* create(MediaControls&); 386 static MediaControlCurrentTimeDisplayElement* create(MediaControls&);
381 387
382 private: 388 private:
383 explicit MediaControlCurrentTimeDisplayElement(MediaControls&); 389 explicit MediaControlCurrentTimeDisplayElement(MediaControls&);
384 }; 390 };
385 391
386 } // namespace blink 392 } // namespace blink
387 393
388 #endif // MediaControlElements_h 394 #endif // MediaControlElements_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698