Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4653)

Unified Diff: ash/common/system/chromeos/tray_tracing.cc

Issue 2700653002: [Ash MD] Remove pre-MD code from TrayImageItem and subclasses (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/chromeos/tray_tracing.cc
diff --git a/ash/common/system/chromeos/tray_tracing.cc b/ash/common/system/chromeos/tray_tracing.cc
index 3663e0f68187dd59ecc873e810ae353d0c82d5ad..cb9e3e4e203f5ae8e2a618539cba54547ed52276 100644
--- a/ash/common/system/chromeos/tray_tracing.cc
+++ b/ash/common/system/chromeos/tray_tracing.cc
@@ -4,7 +4,6 @@
#include "ash/common/system/chromeos/tray_tracing.h"
-#include "ash/common/material_design/material_design_controller.h"
#include "ash/common/metrics/user_metrics_action.h"
#include "ash/common/system/tray/actionable_view.h"
#include "ash/common/system/tray/fixed_sized_image_view.h"
@@ -17,7 +16,6 @@
#include "ash/common/system/tray/tri_view.h"
#include "ash/common/wm_shell.h"
#include "ash/resources/vector_icons/vector_icons.h"
-#include "grit/ash_resources.h"
#include "grit/ash_strings.h"
#include "ui/base/resource/resource_bundle.h"
#include "ui/gfx/image/image.h"
@@ -33,32 +31,25 @@ class DefaultTracingView : public ActionableView {
public:
explicit DefaultTracingView(SystemTrayItem* owner)
: ActionableView(owner, TrayPopupInkDropStyle::FILL_BOUNDS) {
- ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance();
-
SetLayoutManager(new views::FillLayout);
TriView* tri_view = TrayPopupUtils::CreateDefaultRowView();
AddChildView(tri_view);
+
auto image = TrayPopupUtils::CreateMainImageView();
tri_view->AddView(TriView::Container::START, image);
auto label = TrayPopupUtils::CreateDefaultLabel();
label->SetMultiLine(true);
- label->SetText(bundle.GetLocalizedString(IDS_ASH_STATUS_TRAY_TRACING));
+ label->SetText(ui::ResourceBundle::GetSharedInstance().GetLocalizedString(
+ IDS_ASH_STATUS_TRAY_TRACING));
tri_view->AddView(TriView::Container::CENTER, label);
- if (MaterialDesignController::UseMaterialDesignSystemIcons()) {
- TrayPopupItemStyle style(
- TrayPopupItemStyle::FontStyle::DEFAULT_VIEW_LABEL);
- style.SetupLabel(label);
- image->SetImage(
- gfx::CreateVectorIcon(kSystemMenuTracingIcon, style.GetIconColor()));
-
- SetInkDropMode(InkDropHostView::InkDropMode::ON);
- } else {
- // The icon doesn't change in non-md.
- image->SetImage(
- bundle.GetImageNamed(IDR_AURA_UBER_TRAY_TRACING).ToImageSkia());
- }
+ TrayPopupItemStyle style(TrayPopupItemStyle::FontStyle::DEFAULT_VIEW_LABEL);
+ style.SetupLabel(label);
+ image->SetImage(
+ gfx::CreateVectorIcon(kSystemMenuTracingIcon, style.GetIconColor()));
+
+ SetInkDropMode(InkDropHostView::InkDropMode::ON);
}
~DefaultTracingView() override {}
@@ -81,7 +72,7 @@ class DefaultTracingView : public ActionableView {
// ash::TrayTracing
TrayTracing::TrayTracing(SystemTray* system_tray)
- : TrayImageItem(system_tray, IDR_AURA_UBER_TRAY_TRACING, UMA_TRACING),
+ : TrayImageItem(system_tray, kSystemTrayTracingIcon, UMA_TRACING),
default_(nullptr) {
DCHECK(system_tray);
WmShell::Get()->system_tray_notifier()->AddTracingObserver(this);

Powered by Google App Engine
This is Rietveld 408576698