net/nqe/network_qualities_prefs_manager.cc - Issue 2700643002: Increase the NQE cache size from 3 to 10

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/nqe/network_qualities_prefs_manager.cc

Issue 2700643002: Increase the NQE cache size from 3 to 10 (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/nqe/network_qualities_prefs_manager.cc

diff --git a/net/nqe/network_qualities_prefs_manager.cc b/net/nqe/network_qualities_prefs_manager.cc

index e11abd8574cfa60a76d169ca4b919a64c125b750..919cf6cd60c6c1876e7a0fcc044dedee43d8e00d 100644

--- a/net/nqe/network_qualities_prefs_manager.cc

+++ b/net/nqe/network_qualities_prefs_manager.cc

@@ -19,7 +19,7 @@ namespace net {

namespace {

// Maximum size of the prefs that hold the qualities of different networks.

-static const size_t kMaxCacheSize = 3u;

+static const size_t kMaxCacheSize = 10u;

xunjieli 2017/02/16 18:59:57 nit: Can you add a comment here on why big an entr

tbansal1 2017/02/16 21:53:47 Done.

// Parses |value| into a map of NetworkIDs and CachedNetworkQualities,

// and returns the map.

« no previous file with comments | « no previous file | net/nqe/network_qualities_prefs_manager_unittest.cc » ('j') | no next file with comments »