Make sure that the pressure is always 0 for pointerup events

Make sure that the pressure is always 0 for pointerup events

The pressure value is correct on Mac and Windows. We correct them on 
on Android and linux.

Also, for synthetic touch events and touch events from touch emulator, make the pressure 0
for all the touch release events.

BUG=648777
Review-Url: https://codereview.chromium.org/2700623003
Cr-Commit-Position: refs/heads/master@{#452081}
Committed: https://chromium.googlesource.com/chromium/src/+/e1fcfcddcd90de5017009feefa7e18716c450f4e

[lanwei, 2017-02-16 03:08:52]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 03:10:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 05:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:07:01]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[lanwei, 2017-02-16 18:06:25]

Description was changed from

==========
pressure pointer up

BUG=
==========

to

==========
Make sure that the pressure is always 0 for pointerup events



BUG=648777
==========

[lanwei, 2017-02-17 01:47:12]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 01:48:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-02-17 01:49:24]

lanwei@chromium.org changed reviewers:
+ nzolghadr@chromium.org

[lanwei, 2017-02-17 01:49:55]

lanwei@chromium.org changed reviewers:
+ dtapuska@chromium.org, mustaq@chromium.org

[lanwei, 2017-02-17 01:59:58]

Description was changed from

==========
Make sure that the pressure is always 0 for pointerup events



BUG=648777
==========

to

==========
Make sure that the pressure is always 0 for pointerup events

On Android and linux, set the pressure to 0 for touch release events.

Also, for synthetic touch events and touch events from touch emulator, make the
pressure 0 for all the touch release events.



BUG=648777
==========

[lanwei, 2017-02-17 02:00:24]

Description was changed from

==========
Make sure that the pressure is always 0 for pointerup events

On Android and linux, set the pressure to 0 for touch release events.

Also, for synthetic touch events and touch events from touch emulator, make the
pressure 0 for all the touch release events.



BUG=648777
==========

to

==========
Make sure that the pressure is always 0 for pointerup events

On Android and linux, set the pressure to 0 for touch release events.

Also, for synthetic touch events and touch events from touch emulator, make the
pressure 0
for all the touch release events.

BUG=648777
==========

[commit-bot: I haz the power, 2017-02-17 03:51:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 03:51:07]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[lanwei, 2017-02-17 04:13:20]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 04:14:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-02-17 04:16:29]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 04:16:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lanwei, 2017-02-17 04:16:58]

Patchset #3 (id:40001) has been deleted

[lanwei, 2017-02-17 04:17:29]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-02-17 06:30:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 06:30:54]

Dry run: This issue passed the CQ dry run.

[lanwei, 2017-02-17 15:11:35]

Patchset #1 (id:1) has been deleted

[lanwei, 2017-02-17 15:12:52]

Description was changed from

==========
Make sure that the pressure is always 0 for pointerup events

On Android and linux, set the pressure to 0 for touch release events.

Also, for synthetic touch events and touch events from touch emulator, make the
pressure 0
for all the touch release events.

BUG=648777
==========

to

==========
Make sure that the pressure is always 0 for pointerup events

Now, the pressure value is correct on Mac and Windows. We correct them on 
on Android and linux.

Also, for synthetic touch events and touch events from touch emulator, make the
pressure 0
for all the touch release events.

BUG=648777
==========

[lanwei, 2017-02-17 15:13:08]

Description was changed from

==========
Make sure that the pressure is always 0 for pointerup events

Now, the pressure value is correct on Mac and Windows. We correct them on 
on Android and linux.

Also, for synthetic touch events and touch events from touch emulator, make the
pressure 0
for all the touch release events.

BUG=648777
==========

to

==========
Make sure that the pressure is always 0 for pointerup events

The pressure value is correct on Mac and Windows. We correct them on 
on Android and linux.

Also, for synthetic touch events and touch events from touch emulator, make the
pressure 0
for all the touch release events.

BUG=648777
==========

[mustaq, 2017-02-17 16:07:17]

mustaq@chromium.org changed reviewers:
+ tdresser@chromium.org

[mustaq, 2017-02-17 16:07:18]

https://codereview.chromium.org/2700623003/diff/60001/ui/events/android/motio...
File ui/events/android/motion_event_android.cc (right):

https://codereview.chromium.org/2700623003/diff/60001/ui/events/android/motio...
ui/events/android/motion_event_android.cc:307: if (cached_action_ == ACTION_UP)
I guess this came from a previous mistake in Line 232 above: cached_action_ is
of type MotionEvent::Action, so should always be compared/assigned to
MotionEvent::ACTION_UP or MotionEventAndroid::ACTION_UP. ACTION_UP from Java
side is different from MotionEvent::ACTION_UP afaik.

How come we never saw the problem in Line 232? Tim, any idea?

[mustaq, 2017-02-17 16:18:51]

https://codereview.chromium.org/2700623003/diff/60001/ui/events/android/motio...
File ui/events/android/motion_event_android.cc (right):

https://codereview.chromium.org/2700623003/diff/60001/ui/events/android/motio...
ui/events/android/motion_event_android.cc:307: if (cached_action_ == ACTION_UP)
On 2017/02/17 16:07:18, mustaq wrote:
> I guess this came from a previous mistake in Line 232 above: cached_action_ is
> of type MotionEvent::Action, so should always be compared/assigned to
> MotionEvent::ACTION_UP or MotionEventAndroid::ACTION_UP. ACTION_UP from Java
> side is different from MotionEvent::ACTION_UP afaik.
> 
> How come we never saw the problem in Line 232? Tim, any idea?

I have got the answer why we didn't hit Line 232 before ---
ACTION_POINTER_DOWN/UP values just happen to match in these two "definitions":
  -
https://developer.android.com/reference/android/view/MotionEvent.html#ACTION_...
  -
https://cs.chromium.org/chromium/src/ui/events/gesture_detection/motion_event...

Lan, please change this line and Line 232 as well to use MotionEvent::ACTION_*
instead.

And please confirm that Android Chromium build works for pointerup.

[lanwei, 2017-02-17 20:40:49]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 20:41:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:19:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:19:16]

Dry run: This issue passed the CQ dry run.

[mustaq, 2017-02-21 15:10:15]

lgtm

[dtapuska, 2017-02-21 17:16:57]

On 2017/02/21 15:10:15, mustaq wrote:
> lgtm

lgtm

[Navid Zolghadr, 2017-02-21 17:28:34]

lgtm

[lanwei, 2017-02-21 17:47:05]

lanwei@chromium.org changed reviewers:
+ sadrul@chromium.org

[lanwei, 2017-02-21 17:47:06]

sadrul@chromium.org: Please review changes in 

ui/events/, thank you!

https://codereview.chromium.org/2700623003/diff/60001/ui/events/android/motio...
File ui/events/android/motion_event_android.cc (right):

https://codereview.chromium.org/2700623003/diff/60001/ui/events/android/motio...
ui/events/android/motion_event_android.cc:307: if (cached_action_ == ACTION_UP)
On 2017/02/17 16:18:51, mustaq wrote:
> On 2017/02/17 16:07:18, mustaq wrote:
> > I guess this came from a previous mistake in Line 232 above: cached_action_
is
> > of type MotionEvent::Action, so should always be compared/assigned to
> > MotionEvent::ACTION_UP or MotionEventAndroid::ACTION_UP. ACTION_UP from Java
> > side is different from MotionEvent::ACTION_UP afaik.
> > 
> > How come we never saw the problem in Line 232? Tim, any idea?
> 
> I have got the answer why we didn't hit Line 232 before ---
> ACTION_POINTER_DOWN/UP values just happen to match in these two "definitions":
>   -
>
https://developer.android.com/reference/android/view/MotionEvent.html#ACTION_...
>   -
>
https://cs.chromium.org/chromium/src/ui/events/gesture_detection/motion_event...
> 
> Lan, please change this line and Line 232 as well to use MotionEvent::ACTION_*
> instead.
> 
> And please confirm that Android Chromium build works for pointerup.

Acknowledged.

[sadrul, 2017-02-21 19:18:07]

lgtm

https://codereview.chromium.org/2700623003/diff/80001/ui/events/x/events_x_ut...
File ui/events/x/events_x_utils.cc (right):

https://codereview.chromium.org/2700623003/diff/80001/ui/events/x/events_x_ut...
ui/events/x/events_x_utils.cc:728: double force = 0.0;
Wrap everything below in a 'if (event->evtype != TouchEnd)' check

[lanwei, 2017-02-21 22:37:58]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 22:39:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 00:42:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:42:27]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[lanwei, 2017-02-22 01:27:13]

The CQ bit was checked by lanwei@chromium.org

[lanwei, 2017-02-22 01:27:13]

The patchset sent to the CQ was uploaded after l-g-t-m from mustaq@chromium.org,
dtapuska@chromium.org, sadrul@chromium.org, nzolghadr@chromium.org
Link to the patchset: https://codereview.chromium.org/2700623003/#ps100001
(title: "pressure")

[commit-bot: I haz the power, 2017-02-22 01:28:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 03:31:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:31:48]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[lanwei, 2017-02-22 04:33:08]

The CQ bit was checked by lanwei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 04:34:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 07:34:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 07:35:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lanwei, 2017-02-22 15:31:59]

The CQ bit was checked by lanwei@chromium.org

[commit-bot: I haz the power, 2017-02-22 15:32:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 16:39:21]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487777519691170,
"parent_rev": "baff1b62a218ccb26e1fd06f6a192bbabc937ee1", "commit_rev":
"e1fcfcddcd90de5017009feefa7e18716c450f4e"}

[commit-bot: I haz the power, 2017-02-22 16:40:09]

Description was changed from

==========
Make sure that the pressure is always 0 for pointerup events

The pressure value is correct on Mac and Windows. We correct them on 
on Android and linux.

Also, for synthetic touch events and touch events from touch emulator, make the
pressure 0
for all the touch release events.

BUG=648777
==========

to

==========
Make sure that the pressure is always 0 for pointerup events

The pressure value is correct on Mac and Windows. We correct them on 
on Android and linux.

Also, for synthetic touch events and touch events from touch emulator, make the
pressure 0
for all the touch release events.

BUG=648777

Review-Url: https://codereview.chromium.org/2700623003
Cr-Commit-Position: refs/heads/master@{#452081}
Committed:
https://chromium.googlesource.com/chromium/src/+/e1fcfcddcd90de5017009feefa7e...
==========

[commit-bot: I haz the power, 2017-02-22 16:40:11]

Committed patchset #3 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/e1fcfcddcd90de5017009feefa7e...