Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 2700623002: [css-grid] Unskip Automatic Implied Minimum Size tests (Closed)

Created:
3 years, 10 months ago by Manuel Rego
Modified:
3 years, 10 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Unskip Automatic Implied Minimum Size tests The tests have been updated upstream on csswg-test repository, so we don't need to skip them anymore. There are 2 tests failing out of 18 checking this feature: * 007 & 009: These are related to transferred size of replaced grid items (crbug.com/555027). BUG=666940 Review-Url: https://codereview.chromium.org/2700623002 Cr-Commit-Position: refs/heads/master@{#453093} Committed: https://chromium.googlesource.com/chromium/src/+/71efe49d24b1154125e1f07e772151794a156265

Patch Set 1 #

Patch Set 2 : New version unskipping grid-minimum-size-grid-items-005.xht too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Manuel Rego
3 years, 10 months ago (2017-02-15 21:53:13 UTC) #2
cbiesinger
lgtm
3 years, 10 months ago (2017-02-15 21:53:52 UTC) #3
qyearsley
lgtm
3 years, 10 months ago (2017-02-15 21:56:13 UTC) #4
Manuel Rego
Ooops, this has some problems with images, similar to http://crbug.com/692754 but only on Mac (maybe ...
3 years, 10 months ago (2017-02-16 10:22:49 UTC) #5
Manuel Rego
The issues with the images have been fixed on csswg-test already: https://bugs.chromium.org/p/chromium/issues/detail?id=692754#c1 So we can ...
3 years, 10 months ago (2017-02-25 14:33:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700623002/20001
3 years, 10 months ago (2017-02-25 14:33:41 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 15:18:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/71efe49d24b1154125e1f07e7721...

Powered by Google App Engine
This is Rietveld 408576698