Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2700563007: Clean up DeviceInfoQueryWin. (Closed)

Created:
3 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
juncai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up DeviceInfoQueryWin. Switch to using DEVPROPKEYs and std::string arguments instead of the legacy integer property IDs and raw C strings. BUG=None Review-Url: https://codereview.chromium.org/2700563007 Cr-Commit-Position: refs/heads/master@{#452070} Committed: https://chromium.googlesource.com/chromium/src/+/0a2373993fd8c9b7eafb1993e905c9b4386aad9a

Patch Set 1 #

Patch Set 2 : Add INITGUID to serial_io_handler_win.cc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -24 lines) Patch
M device/base/device_info_query_win.h View 1 chunk +3 lines, -2 lines 0 comments Download
M device/base/device_info_query_win.cc View 3 chunks +18 lines, -17 lines 0 comments Download
M device/serial/serial_io_handler_win.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M device/usb/usb_service_impl.cc View 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 10 months ago (2017-02-18 01:06:08 UTC) #3
juncai
LGTM.
3 years, 10 months ago (2017-02-21 18:48:52 UTC) #7
Reilly Grant (use Gerrit)
Add INITGUID to serial_io_handler_win.cc.
3 years, 10 months ago (2017-02-22 01:52:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700563007/20001
3 years, 10 months ago (2017-02-22 01:54:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-22 03:58:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700563007/20001
3 years, 10 months ago (2017-02-22 15:54:13 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 16:08:33 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0a2373993fd8c9b7eafb1993e905...

Powered by Google App Engine
This is Rietveld 408576698