Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2700443002: Fix MetricsServiceClients to use SyncDisableObservers state. (Closed)

Created:
3 years, 10 months ago by Steven Holte
Modified:
3 years, 10 months ago
Reviewers:
rkaplow, Olivier
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, asvitkine+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MetricsServiceClients to use SyncDisableObservers state. Currently, the clients are using the default client implementation instead of using the actual observed value, so UKM is always disabled. BUG=678682 Review-Url: https://codereview.chromium.org/2700443002 Cr-Commit-Position: refs/heads/master@{#450813} Committed: https://chromium.googlesource.com/chromium/src/+/08137d79be70c84d73209e278c7e3f0a67f4442e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Steven Holte
3 years, 10 months ago (2017-02-15 00:45:17 UTC) #3
rkaplow
lgtm
3 years, 10 months ago (2017-02-15 01:57:25 UTC) #4
Olivier
ios LGTM
3 years, 10 months ago (2017-02-15 10:23:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700443002/1
3 years, 10 months ago (2017-02-15 19:49:27 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 21:44:36 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08137d79be70c84d73209e278c7e...

Powered by Google App Engine
This is Rietveld 408576698