Chromium Code Reviews
Help | Chromium Project | Sign in
(70)

Issue 2700433005: Fix --disable-gpu-vsync on windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by jbauman
Modified:
1 month ago
Reviewers:
sunnyps
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix --disable-gpu-vsync on windows. The GLSurfaceEGL wasn't being properly notified about the new vsync interval. BUG=480361 Review-Url: https://codereview.chromium.org/2700433005 Cr-Commit-Position: refs/heads/master@{#451249} Committed: https://chromium.googlesource.com/chromium/src/+/c1dd762facbeb164cedf88e07ba7f46458d49659

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ui/gl/gl_surface.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_surface.cc View 1 chunk +4 lines, -0 lines 0 comments Download
Trybot results:  linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   linux_chromium_tsan_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   chromeos_daisy_chromium_compile_only_ng   linux_chromium_compile_dbg_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   win_chromium_x64_rel_ng   win_chromium_rel_ng   linux_android_rel_ng   android_clang_dbg_recipe   android_arm64_dbg_recipe   win_chromium_compile_dbg_ng   mac_chromium_rel_ng   win_clang   android_compile_dbg   cast_shell_android   ios-simulator-xcode-clang   mac_chromium_compile_dbg_ng   ios-device   ios-simulator   ios-device-xcode-clang   android_cronet   chromium_presubmit   linux_chromium_rel_ng   android_n5x_swarming_rel   android_n5x_swarming_rel   win_clang   win_chromium_x64_rel_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios-simulator-xcode-clang   ios-device-xcode-clang   ios-simulator   ios-device   linux_chromium_tsan_rel_ng   linux_chromium_rel_ng   linux_chromium_compile_dbg_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_asan_rel_ng   chromium_presubmit   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   linux_android_rel_ng   cast_shell_android   android_n5x_swarming_rel   android_cronet   android_compile_dbg   android_clang_dbg_recipe   android_arm64_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (10 generated)
jbauman
1 month, 1 week ago (2017-02-16 02:06:29 UTC) #5
sunnyps
Please format the CL description to 80 cols and include the bug id (480361). lgtm
1 month, 1 week ago (2017-02-16 02:15:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700433005/1
1 month ago (2017-02-16 23:52:46 UTC) #11
commit-bot: I haz the power
1 month ago (2017-02-17 06:36:52 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c1dd762facbeb164cedf88e07ba7...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld d1a128a62