Update BitWriter buffer position on flush.

Update BitWriter buffer position on flush.

When a BitWriter is flushed (through BitWriter::Flush()) the buffer
position is not updated even though additional bits are written. When the
BitWriter is used after the flush, BitWriter::position() would return
incorrect positions.

This CL fixes the behavior by updating |position_| in BitWriter::Flush()
to account for the padding bits (8 - |used_|).

Also removes BitWriter::BitLength() which is unused.

BUG=595493
Review-Url: https://codereview.chromium.org/2700433004
Cr-Commit-Position: refs/heads/master@{#450923}
Committed: https://chromium.googlesource.com/chromium/src/+/39a7d963f56666f34a337c87c4ddc8d432b1c39c

[martijnc, 2017-02-15 19:56:01]

Description was changed from

==========
Fix BitWriter buffer position on flush.

When a BitWriter is flushed (through BitWriter::flush()) the buffer
position is not updated even though bits are written. When the
BitWriter is used after the flush,
BitWriter::position() would return an incorrect position.



BUG=595493
==========

to

==========
Update BitWriter buffer position on flush.

When a BitWriter is flushed (through BitWriter::flush()) the buffer
position is not updated even though additional bits are written. When the
BitWriter is used after the flush, BitWriter::position() would return
incorrect positions.

This CL fixes the behavior by updating |position_| in BitWriter::Flush()
to account for the padding bits (8 - |used_|).

BUG=595493
==========

[martijnc, 2017-02-15 19:56:01]

martijn@martijnc.be changed reviewers:
+ rsleevi@chromium.org

[martijnc, 2017-02-15 20:05:49]

Patchset #1 (id:1) has been deleted

[martijnc, 2017-02-15 20:06:04]

Patchset #1 (id:20001) has been deleted

[martijnc, 2017-02-15 20:08:01]

Description was changed from

==========
Update BitWriter buffer position on flush.

When a BitWriter is flushed (through BitWriter::flush()) the buffer
position is not updated even though additional bits are written. When the
BitWriter is used after the flush, BitWriter::position() would return
incorrect positions.

This CL fixes the behavior by updating |position_| in BitWriter::Flush()
to account for the padding bits (8 - |used_|).

BUG=595493
==========

to

==========
Update BitWriter buffer position on flush.

When a BitWriter is flushed (through BitWriter::flush()) the buffer
position is not updated even though additional bits are written. When the
BitWriter is used after the flush, BitWriter::position() would return
incorrect positions.

This CL fixes the behavior by updating |position_| in BitWriter::Flush()
to account for the padding bits (8 - |used_|).

Also removes BitWriter::BitLength() which is unused.

BUG=595493
==========

[martijnc, 2017-02-15 22:09:26]

This is split off from https://codereview.chromium.org/2681733008.

[Ryan Sleevi, 2017-02-16 01:40:37]

Description was changed from

==========
Update BitWriter buffer position on flush.

When a BitWriter is flushed (through BitWriter::flush()) the buffer
position is not updated even though additional bits are written. When the
BitWriter is used after the flush, BitWriter::position() would return
incorrect positions.

This CL fixes the behavior by updating |position_| in BitWriter::Flush()
to account for the padding bits (8 - |used_|).

Also removes BitWriter::BitLength() which is unused.

BUG=595493
==========

to

==========
Update BitWriter buffer position on flush.

When a BitWriter is flushed (through BitWriter::Flush()) the buffer
position is not updated even though additional bits are written. When the
BitWriter is used after the flush, BitWriter::position() would return
incorrect positions.

This CL fixes the behavior by updating |position_| in BitWriter::Flush()
to account for the padding bits (8 - |used_|).

Also removes BitWriter::BitLength() which is unused.

BUG=595493
==========

[Ryan Sleevi, 2017-02-16 01:40:56]

LGTM

Thanks for making super digestable and easy to review :)

[martijnc, 2017-02-16 08:41:50]

The CQ bit was checked by martijn@martijnc.be

[commit-bot: I haz the power, 2017-02-16 08:43:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 10:13:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487234510155620,
"parent_rev": "7c15aa049a9c754139c3320bae7ab69c93919e68", "commit_rev":
"39a7d963f56666f34a337c87c4ddc8d432b1c39c"}

[commit-bot: I haz the power, 2017-02-16 10:13:46]

Description was changed from

==========
Update BitWriter buffer position on flush.

When a BitWriter is flushed (through BitWriter::Flush()) the buffer
position is not updated even though additional bits are written. When the
BitWriter is used after the flush, BitWriter::position() would return
incorrect positions.

This CL fixes the behavior by updating |position_| in BitWriter::Flush()
to account for the padding bits (8 - |used_|).

Also removes BitWriter::BitLength() which is unused.

BUG=595493
==========

to

==========
Update BitWriter buffer position on flush.

When a BitWriter is flushed (through BitWriter::Flush()) the buffer
position is not updated even though additional bits are written. When the
BitWriter is used after the flush, BitWriter::position() would return
incorrect positions.

This CL fixes the behavior by updating |position_| in BitWriter::Flush()
to account for the padding bits (8 - |used_|).

Also removes BitWriter::BitLength() which is unused.

BUG=595493

Review-Url: https://codereview.chromium.org/2700433004
Cr-Commit-Position: refs/heads/master@{#450923}
Committed:
https://chromium.googlesource.com/chromium/src/+/39a7d963f56666f34a337c87c4dd...
==========

[commit-bot: I haz the power, 2017-02-16 10:13:47]

Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/39a7d963f56666f34a337c87c4dd...