Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2700343003: Recover better from illegally named constructors (issue 28807) (Closed)

Created:
3 years, 10 months ago by Brian Wilkerson
Modified:
3 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Recover better from illegally named constructors (issue 28807) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f64bad806b549d42e018956208b481eaec889f39

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M pkg/analyzer/lib/src/dart/error/syntactic_errors.dart View 1 chunk +5 lines, -0 lines 2 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 4 chunks +17 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 10 months ago (2017-02-18 17:20:43 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2700343003/diff/1/pkg/analyzer/lib/src/dart/error/syntactic_errors.dart File pkg/analyzer/lib/src/dart/error/syntactic_errors.dart (right): https://codereview.chromium.org/2700343003/diff/1/pkg/analyzer/lib/src/dart/error/syntactic_errors.dart#newcode455 pkg/analyzer/lib/src/dart/error/syntactic_errors.dart:455: "The keyword word '{0}' cannot be used to ...
3 years, 10 months ago (2017-02-18 17:37:40 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2700343003/diff/1/pkg/analyzer/lib/src/dart/error/syntactic_errors.dart File pkg/analyzer/lib/src/dart/error/syntactic_errors.dart (right): https://codereview.chromium.org/2700343003/diff/1/pkg/analyzer/lib/src/dart/error/syntactic_errors.dart#newcode455 pkg/analyzer/lib/src/dart/error/syntactic_errors.dart:455: "The keyword word '{0}' cannot be used to name ...
3 years, 10 months ago (2017-02-18 17:48:01 UTC) #4
Brian Wilkerson
3 years, 10 months ago (2017-02-18 17:48:12 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
f64bad806b549d42e018956208b481eaec889f39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698