Recover better from illegally named constructors (issue 28807)

pkg/analyzer/lib/src/dart/error/syntactic_errors.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * The errors produced during syntactic analysis (scanning and parsing).
  */
 library analyzer.src.dart.error.syntactic_errors;
 
 import 'package:analyzer/error/error.dart';
@@ skipping 432 matching lines @@
    */
   static const ParserErrorCode INVALID_CODE_POINT = const ParserErrorCode(
       'INVALID_CODE_POINT',
       "The escape sequence '{0}' isn't a valid code point.");
 
   static const ParserErrorCode INVALID_COMMENT_REFERENCE = const ParserErrorCode(
       'INVALID_COMMENT_REFERENCE',
       "Comment references should contain a possibly prefixed identifier and "
       "can start with 'new', but shouldn't contain anything else.");
 
+  static const ParserErrorCode INVALID_CONSTRUCTOR_NAME = const ParserErrorCode(
+      'INVALID_CONSTRUCTOR_NAME',
+      "The keyword word '{0}' cannot be used to name a constructor.",

[scheglov, 2017/02/18 17:37:40]

Do we need to repeat "word"?

[Brian Wilkerson, 2017/02/18 17:48:01]

Removed, thanks!

+      "Try giving the constructor a different name.");
+
   static const ParserErrorCode INVALID_HEX_ESCAPE = const ParserErrorCode(
       'INVALID_HEX_ESCAPE',
       "An escape sequence starting with '\\x' must be followed by 2 hexidecimal digits.");
 
   static const ParserErrorCode INVALID_LITERAL_IN_CONFIGURATION =
       const ParserErrorCode(
           'INVALID_LITERAL_IN_CONFIGURATION',
           "The literal in a configuration can't contain interpolation.",
           "Try removing the interpolation expressions.");
 
@@ skipping 523 matching lines @@
    */
   const ParserErrorCode(String name, String message, [String correction])
       : super(name, message, correction);
 
   @override
   ErrorSeverity get errorSeverity => ErrorSeverity.ERROR;
 
   @override
   ErrorType get type => ErrorType.SYNTACTIC_ERROR;
 }