Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3968)

Unified Diff: chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Issue 2700303002: cros: Unify oobe View/Actor naming to just View. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/wizard_controller_browsertest.cc
diff --git a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
index ebebd51e98a5ca380df8ab5b95692acb27c84ed9..d1b281ba4f0d6f8fc7010300894dc62bd1378e7d 100644
--- a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
+++ b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
@@ -25,7 +25,7 @@
#include "chrome/browser/chromeos/login/screens/device_disabled_screen.h"
#include "chrome/browser/chromeos/login/screens/error_screen.h"
#include "chrome/browser/chromeos/login/screens/hid_detection_screen.h"
-#include "chrome/browser/chromeos/login/screens/mock_device_disabled_screen_actor.h"
+#include "chrome/browser/chromeos/login/screens/mock_device_disabled_screen_view.h"
#include "chrome/browser/chromeos/login/screens/mock_enable_debugging_screen.h"
#include "chrome/browser/chromeos/login/screens/mock_eula_screen.h"
#include "chrome/browser/chromeos/login/screens/mock_network_screen.h"
@@ -200,13 +200,12 @@ template <class T, class H>
class MockOutShowHide : public T {
public:
template <class P> explicit MockOutShowHide(P p) : T(p) {}
- template <class P> MockOutShowHide(P p, H* actor)
- : T(p, actor), actor_(actor) {}
+ template <class P>
+ MockOutShowHide(P p, H* view) : T(p, view), view_(view) {}
template <class P, class Q>
- MockOutShowHide(P p, Q q, H* actor)
- : T(p, q, actor), actor_(actor) {}
+ MockOutShowHide(P p, Q q, H* view) : T(p, q, view), view_(view) {}
- H* actor() const { return actor_.get(); }
+ H* view() const { return view_.get(); }
MOCK_METHOD0(Show, void());
MOCK_METHOD0(Hide, void());
@@ -220,7 +219,7 @@ class MockOutShowHide : public T {
}
private:
- std::unique_ptr<H> actor_;
+ std::unique_ptr<H> view_;
};
#define MOCK(mock_var, screen_name, mocked_class, actor_class) \
@@ -442,7 +441,7 @@ class WizardControllerFlowTest : public WizardControllerTest {
MOCK(mock_enable_debugging_screen_,
OobeScreen::SCREEN_OOBE_ENABLE_DEBUGGING, MockEnableDebuggingScreen,
MockEnableDebuggingScreenActor);
- device_disabled_screen_actor_.reset(new MockDeviceDisabledScreenActor);
+ device_disabled_screen_actor_.reset(new MockDeviceDisabledScreenView);
wizard_controller->screens_[OobeScreen::SCREEN_DEVICE_DISABLED] =
make_linked_ptr(new DeviceDisabledScreen(
wizard_controller, device_disabled_screen_actor_.get()));
@@ -528,7 +527,7 @@ class WizardControllerFlowTest : public WizardControllerTest {
mock_wrong_hwid_screen_;
MockOutShowHide<MockEnableDebuggingScreen,
MockEnableDebuggingScreenActor>* mock_enable_debugging_screen_;
- std::unique_ptr<MockDeviceDisabledScreenActor> device_disabled_screen_actor_;
+ std::unique_ptr<MockDeviceDisabledScreenView> device_disabled_screen_actor_;
private:
NetworkPortalDetectorTestImpl* network_portal_detector_;
@@ -672,7 +671,7 @@ IN_PROC_BROWSER_TEST_F(WizardControllerFlowTest, ControlFlowSkipUpdateEnroll) {
EXPECT_CALL(*mock_update_screen_, StartNetworkCheck()).Times(0);
EXPECT_CALL(*mock_update_screen_, Show()).Times(0);
WizardController::default_controller()->SkipUpdateEnrollAfterEula();
- EXPECT_CALL(*mock_enrollment_screen_->actor(),
+ EXPECT_CALL(*mock_enrollment_screen_->view(),
SetParameters(
mock_enrollment_screen_,
EnrollmentModeMatches(policy::EnrollmentConfig::MODE_MANUAL)))
@@ -715,7 +714,7 @@ IN_PROC_BROWSER_TEST_F(WizardControllerFlowTest,
ControlFlowEnrollmentCompleted) {
CheckCurrentScreen(OobeScreen::SCREEN_OOBE_NETWORK);
EXPECT_CALL(*mock_update_screen_, StartNetworkCheck()).Times(0);
- EXPECT_CALL(*mock_enrollment_screen_->actor(),
+ EXPECT_CALL(*mock_enrollment_screen_->view(),
SetParameters(
mock_enrollment_screen_,
EnrollmentModeMatches(policy::EnrollmentConfig::MODE_MANUAL)))
@@ -877,7 +876,7 @@ IN_PROC_BROWSER_TEST_F(WizardControllerDeviceStateTest,
g_browser_process->local_state()->Set(prefs::kServerBackedDeviceState,
device_state);
EXPECT_CALL(*mock_enrollment_screen_, Show()).Times(1);
- EXPECT_CALL(*mock_enrollment_screen_->actor(),
+ EXPECT_CALL(*mock_enrollment_screen_->view(),
SetParameters(mock_enrollment_screen_,
EnrollmentModeMatches(
policy::EnrollmentConfig::MODE_SERVER_FORCED)))
@@ -1112,7 +1111,7 @@ class WizardControllerKioskFlowTest : public WizardControllerFlowTest {
IN_PROC_BROWSER_TEST_F(WizardControllerKioskFlowTest,
ControlFlowKioskForcedEnrollment) {
- EXPECT_CALL(*mock_enrollment_screen_->actor(),
+ EXPECT_CALL(*mock_enrollment_screen_->view(),
SetParameters(mock_enrollment_screen_,
EnrollmentModeMatches(
policy::EnrollmentConfig::MODE_LOCAL_FORCED)))
@@ -1154,7 +1153,7 @@ IN_PROC_BROWSER_TEST_F(WizardControllerKioskFlowTest,
IN_PROC_BROWSER_TEST_F(WizardControllerKioskFlowTest,
ControlFlowEnrollmentBack) {
- EXPECT_CALL(*mock_enrollment_screen_->actor(),
+ EXPECT_CALL(*mock_enrollment_screen_->view(),
SetParameters(mock_enrollment_screen_,
EnrollmentModeMatches(
policy::EnrollmentConfig::MODE_LOCAL_FORCED)))
@@ -1283,7 +1282,7 @@ IN_PROC_BROWSER_TEST_F(WizardControllerOobeResumeTest,
WizardController::default_controller()->AdvanceToScreen(
OobeScreen::SCREEN_OOBE_NETWORK);
CheckCurrentScreen(OobeScreen::SCREEN_OOBE_NETWORK);
- EXPECT_CALL(*mock_enrollment_screen_->actor(),
+ EXPECT_CALL(*mock_enrollment_screen_->view(),
SetParameters(
mock_enrollment_screen_,
EnrollmentModeMatches(policy::EnrollmentConfig::MODE_MANUAL)))

Powered by Google App Engine
This is Rietveld 408576698