Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: chrome/browser/chromeos/arc/arc_session_manager_unittest.cc

Issue 2700303002: cros: Unify oobe View/Actor naming to just View. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
diff --git a/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc b/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
index 98d8e1479b2739542722559283209265f5671b64..df3e709f97fe1b78f8424b8d2b925ad5bb68b3b8 100644
--- a/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
+++ b/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
@@ -22,8 +22,8 @@
#include "chrome/browser/chromeos/arc/arc_session_manager.h"
#include "chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h"
#include "chrome/browser/chromeos/arc/test/arc_data_removed_waiter.h"
-#include "chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_actor.h"
-#include "chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_actor_observer.h"
+#include "chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_view.h"
+#include "chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_view_observer.h"
#include "chrome/browser/chromeos/login/ui/login_display_host.h"
#include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
#include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
@@ -717,7 +717,7 @@ TEST_F(ArcSessionOobeOptInTest, OobeOptInActive) {
class ArcSessionOobeOptInNegotiatorTest
: public ArcSessionOobeOptInTest,
- public chromeos::ArcTermsOfServiceScreenActor,
+ public chromeos::ArcTermsOfServiceScreenView,
public testing::WithParamInterface<bool> {
public:
ArcSessionOobeOptInNegotiatorTest() = default;
@@ -772,7 +772,7 @@ class ArcSessionOobeOptInNegotiatorTest
void ReportActorDestroyed() {
hidehiko 2017/02/23 05:34:07 s/Actor/View/ here, too?
jdufault 2017/02/24 00:40:15 Done.
for (auto& observer : observer_list_)
- observer.OnActorDestroyed(this);
+ observer.OnViewDestroyed(this);
base::RunLoop().RunUntilIdle();
}
@@ -788,17 +788,17 @@ class ArcSessionOobeOptInNegotiatorTest
ArcDataRemovedWaiter().Wait();
}
- chromeos::ArcTermsOfServiceScreenActor* actor() { return this; }
+ chromeos::ArcTermsOfServiceScreenView* view() { return this; }
private:
- // ArcTermsOfServiceScreenActor:
+ // ArcTermsOfServiceScreenView:
void AddObserver(
- chromeos::ArcTermsOfServiceScreenActorObserver* observer) override {
+ chromeos::ArcTermsOfServiceScreenViewObserver* observer) override {
observer_list_.AddObserver(observer);
}
void RemoveObserver(
- chromeos::ArcTermsOfServiceScreenActorObserver* observer) override {
+ chromeos::ArcTermsOfServiceScreenViewObserver* observer) override {
observer_list_.RemoveObserver(observer);
}
@@ -810,7 +810,7 @@ class ArcSessionOobeOptInNegotiatorTest
void Hide() override {}
- base::ObserverList<chromeos::ArcTermsOfServiceScreenActorObserver>
+ base::ObserverList<chromeos::ArcTermsOfServiceScreenViewObserver>
observer_list_;
DISALLOW_COPY_AND_ASSIGN(ArcSessionOobeOptInNegotiatorTest);
@@ -821,7 +821,7 @@ INSTANTIATE_TEST_CASE_P(ArcSessionOobeOptInNegotiatorTestImpl,
::testing::Values(true, false));
TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsAccepted) {
- actor()->Show();
+ view()->Show();
MaybeWaitForDataRemoved();
EXPECT_EQ(ArcSessionManager::State::SHOWING_TERMS_OF_SERVICE,
arc_session_manager()->state());
@@ -831,7 +831,7 @@ TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsAccepted) {
}
TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsRejected) {
- actor()->Show();
+ view()->Show();
MaybeWaitForDataRemoved();
EXPECT_EQ(ArcSessionManager::State::SHOWING_TERMS_OF_SERVICE,
arc_session_manager()->state());
@@ -842,7 +842,7 @@ TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsRejected) {
}
TEST_P(ArcSessionOobeOptInNegotiatorTest, OobeTermsActorDestroyed) {
hidehiko 2017/02/23 05:34:07 s/Actor/View/ too_
jdufault 2017/02/24 00:40:15 Done.
- actor()->Show();
+ view()->Show();
MaybeWaitForDataRemoved();
EXPECT_EQ(ArcSessionManager::State::SHOWING_TERMS_OF_SERVICE,
arc_session_manager()->state());

Powered by Google App Engine
This is Rietveld 408576698