Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2700263002: Revert of [Telemetry] Migrate browser_test_runner to use typ as the test runner (Closed)

Created:
3 years, 10 months ago by nednguyen
Modified:
3 years, 10 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Migrate browser_test_runner to use typ as the test runner (patchset #1 id:1 of https://codereview.chromium.org/2700563004/ ) Reason for revert: Revert to unblock other catapult change from rolling out Original issue's description: > [Telemetry] Migrate browser_test_runner to use typ as the test runner > > BUG=chromium:636153 > TBR=kbr@chromium.org > > Review-Url: https://codereview.chromium.org/2700563004 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9b622e90afea69ce108960f0215cc468d06d4955 TBR=kbr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:636153 Review-Url: https://codereview.chromium.org/2700263002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/dfe99bd99d0307e28035105fe31f8946a8d6184c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+434 lines, -722 lines) Patch
M telemetry/bin/run_browser_tests View 1 chunk +2 lines, -1 line 0 comments Download
M telemetry/examples/browser_tests/failed_tests.py View 2 chunks +2 lines, -2 lines 0 comments Download
D telemetry/examples/browser_tests/process_tests.py View 1 chunk +0 lines, -53 lines 0 comments Download
D telemetry/examples/browser_tests/sample_unittest.py View 1 chunk +0 lines, -12 lines 0 comments Download
M telemetry/examples/browser_tests/simple_browser_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
D telemetry/telemetry/testing/browser_test_context.py View 1 chunk +0 lines, -74 lines 0 comments Download
M telemetry/telemetry/testing/browser_test_runner.py View 1 chunk +309 lines, -33 lines 0 comments Download
M telemetry/telemetry/testing/browser_test_runner_unittest.py View 10 chunks +111 lines, -162 lines 0 comments Download
D telemetry/telemetry/testing/run_browser_tests.py View 1 chunk +0 lines, -357 lines 0 comments Download
M telemetry/telemetry/testing/serially_executed_browser_test_case.py View 4 chunks +8 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
nednguyen
Created Revert of [Telemetry] Migrate browser_test_runner to use typ as the test runner
3 years, 10 months ago (2017-02-17 22:51:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700263002/1
3 years, 10 months ago (2017-02-17 22:51:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/dfe99bd99d0307e28035105fe31f8946a8d6184c
3 years, 10 months ago (2017-02-17 23:13:36 UTC) #6
Ken Russell (switch to Gerrit)
lgtm after the fact. Let's try to make this switchover early next week instead.
3 years, 10 months ago (2017-02-18 00:55:32 UTC) #7
nednguyen
3 years, 10 months ago (2017-02-21 20:58:32 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2701253008/ by nednguyen@google.com.

The reason for reverting is: Reland to roll out the change.

Powered by Google App Engine
This is Rietveld 408576698