Remove unnecessary window WebAudio attributes

Remove unnecessary window WebAudio attributes

These attributes were added to measure the usage of the new WebAudio constructors.  This has been replaced with a different scheme using the IDL files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter entries are also removed.

BUG=693735
TEST=none

Review-Url: https://codereview.chromium.org/2700233003
Cr-Commit-Position: refs/heads/master@{#453259}
Committed: https://chromium.googlesource.com/chromium/src/+/9f058d69c1820c58ca8df07865b7021e5ba3030f

[Raymond Toy, 2017-02-17 22:04:17]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 22:05:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 00:09:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 00:09:40]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Raymond Toy, 2017-02-21 21:31:19]

rtoy@chromium.org changed reviewers:
+ foolip@chromium.org, hongchan@chromium.org

[Raymond Toy, 2017-02-21 21:31:19]

foolip@  Is this what you're thinking of in removing all of the attributes for
the constructors?

[hongchan, 2017-02-22 19:08:12]

On 2017/02/21 21:31:19, Raymond Toy wrote:
> foolip@  Is this what you're thinking of in removing all of the attributes for
> the constructors?

Then how do we track these from now on? Where is the tracking happening?

[Raymond Toy, 2017-02-22 19:22:44]

On 2017/02/22 19:08:12, hongchan wrote:
> On 2017/02/21 21:31:19, Raymond Toy wrote:
> > foolip@  Is this what you're thinking of in removing all of the attributes
for
> > the constructors?
> 
> Then how do we track these from now on? Where is the tracking happening?

In each idl file for the node, we now have a Measure, which shows up in the
metrics as V8<NodeName>.

(We added this recently; I didn't know such a thing existed.)

[Raymond Toy, 2017-02-22 19:25:00]

On 2017/02/22 19:22:44, Raymond Toy wrote:
> On 2017/02/22 19:08:12, hongchan wrote:
> > On 2017/02/21 21:31:19, Raymond Toy wrote:
> > > foolip@  Is this what you're thinking of in removing all of the attributes
> for
> > > the constructors?
> > 
> > Then how do we track these from now on? Where is the tracking happening?
> 
> In each idl file for the node, we now have a Measure, which shows up in the
> metrics as V8<NodeName>.
> 
> (We added this recently; I didn't know such a thing existed.)

Er, V8<NodeName>_Constructor, such as V8GainNode_Constructor

[foolip, 2017-02-23 02:32:09]

lgtm % UseCounter.h

https://codereview.chromium.org/2700233003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl (left):

https://codereview.chromium.org/2700233003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl:9:
[MeasureAs=WebAudioAnalyserNode] attribute AnalyserNodeConstructor AnalyserNode;
Can you also remove all of these from UseCounter.h? The new ones for the
constructors have separate entries.

[Raymond Toy, 2017-02-23 16:44:32]

On 2017/02/23 02:32:09, foolip wrote:
> lgtm % UseCounter.h
> 
>
https://codereview.chromium.org/2700233003/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl (left):
> 
>
https://codereview.chromium.org/2700233003/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl:9:
> [MeasureAs=WebAudioAnalyserNode] attribute AnalyserNodeConstructor
AnalyserNode;
> Can you also remove all of these from UseCounter.h? The new ones for the
> constructors have separate entries.

Will do.

I confess though, that I can't make sense of WebAudioGainNode
(https://www.chromestatus.com/metrics/feature/timeline/popularity/1570) vs
V8GainNode_Constructor
(https://www.chromestatus.com/metrics/feature/timeline/popularity/1714)

Perhaps WebAudioGainNode wasn't really measuring what I wanted? 
V8GainNode_Constructor kind of matches my expectations of low usage, slowly
growing over time (except for that spike).  I think only Chrome as the
constructors launched. (FF coming soon, I think)

[Raymond Toy, 2017-02-23 16:55:48]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 16:56:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2017-02-23 18:20:49]

On 2017/02/23 16:44:32, Raymond Toy wrote:
> On 2017/02/23 02:32:09, foolip wrote:
> > lgtm % UseCounter.h
> > 
> >
>
https://codereview.chromium.org/2700233003/diff/1/third_party/WebKit/Source/m...
> > File third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl (left):
> > 
> >
>
https://codereview.chromium.org/2700233003/diff/1/third_party/WebKit/Source/m...
> > third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl:9:
> > [MeasureAs=WebAudioAnalyserNode] attribute AnalyserNodeConstructor
> AnalyserNode;
> > Can you also remove all of these from UseCounter.h? The new ones for the
> > constructors have separate entries.
> 
> Will do.
> 
> I confess though, that I can't make sense of WebAudioGainNode
> (https://www.chromestatus.com/metrics/feature/timeline/popularity/1570) vs
> V8GainNode_Constructor
> (https://www.chromestatus.com/metrics/feature/timeline/popularity/1714)
> 
> Perhaps WebAudioGainNode wasn't really measuring what I wanted? 
> V8GainNode_Constructor kind of matches my expectations of low usage, slowly
> growing over time (except for that spike).  I think only Chrome as the
> constructors launched. (FF coming soon, I think)

Right, WebAudioGainNode and friends never measured anything very meaningful. Any
access of the window.WebAudioGainNode property would trigger it, and due to
enumeration of all attributes on window, the real usage is hard to ascertain.
The very similar usage graphs for the different nodes certainly suggests to me
that usage was dominated by enumeration and not actual Web Audio code.

[commit-bot: I haz the power, 2017-02-23 18:45:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 18:45:21]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2017-02-23 19:26:46]

Description was changed from

==========
Remove unnecessary attributes

BUG=693735
TEST=none
==========

to

==========
Remove unnecessary window WebAudio attributes

These attributes were added to measure the usage of the new WebAudio
constructors.  This has been replaced with a different scheme using the IDL
files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter
entries are also removed.

BUG=693735
TEST=none
==========

[Raymond Toy, 2017-02-23 19:27:17]

PTAL

[foolip, 2017-02-23 19:39:38]

lgtm % another nit

https://codereview.chromium.org/2700233003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl (right):

https://codereview.chromium.org/2700233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl:7: ] partial
interface Window {
Oh, I didn't notice this partial interface actually becomes empty. Can you
remove the file entirely, together with the dummy DOMWindowWebAudio.h?

[Raymond Toy, 2017-02-24 17:02:52]

https://codereview.chromium.org/2700233003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl (right):

https://codereview.chromium.org/2700233003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/WindowWebAudio.idl:7: ] partial
interface Window {
On 2017/02/23 19:39:38, foolip wrote:
> Oh, I didn't notice this partial interface actually becomes empty. Can you
> remove the file entirely, together with the dummy DOMWindowWebAudio.h?

Done.

[Raymond Toy, 2017-02-24 17:05:16]

rtoy@chromium.org changed reviewers:
+ haraken@chromium.org

[Raymond Toy, 2017-02-24 17:05:17]

haraken@chromium.org: Please review changes in 

UseCounter.h and modules_idl_files.gni

[hongchan, 2017-02-24 23:13:54]

lgtm

[haraken, 2017-02-24 23:57:20]

LGTM

[Raymond Toy, 2017-02-27 16:12:05]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-02-27 16:12:05]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2700233003/#ps40001
(title: "Remove WindowWebAudio.idl")

[commit-bot: I haz the power, 2017-02-27 16:12:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 18:12:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488211925076020,
"parent_rev": "2b7b343f00720cb53ac5b10918125037ee03deb0", "commit_rev":
"9f058d69c1820c58ca8df07865b7021e5ba3030f"}

[commit-bot: I haz the power, 2017-02-27 18:12:39]

Description was changed from

==========
Remove unnecessary window WebAudio attributes

These attributes were added to measure the usage of the new WebAudio
constructors.  This has been replaced with a different scheme using the IDL
files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter
entries are also removed.

BUG=693735
TEST=none
==========

to

==========
Remove unnecessary window WebAudio attributes

These attributes were added to measure the usage of the new WebAudio
constructors.  This has been replaced with a different scheme using the IDL
files to specify measurement.

Thus, these are obsolete and should be removed.  The corresponding UseCounter
entries are also removed.

BUG=693735
TEST=none

Review-Url: https://codereview.chromium.org/2700233003
Cr-Commit-Position: refs/heads/master@{#453259}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f058d69c1820c58ca8df07865b7...
==========

[commit-bot: I haz the power, 2017-02-27 18:12:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9f058d69c1820c58ca8df07865b7...