Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 270023002: fix TriColorShader to respect the paint's alpha (Closed)

Created:
6 years, 7 months ago by reed1
Modified:
6 years, 7 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

fix TriColorShader to respect the paint's alpha results can be seen in new gm: vertices_80 BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14581

Patch Set 1 #

Total comments: 4

Patch Set 2 : add Sk255To256 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M include/core/SkColorPriv.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/core/SkDraw.cpp View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reed1
6 years, 7 months ago (2014-05-05 21:00:39 UTC) #1
scroggo
lgtm https://codereview.chromium.org/270023002/diff/1/src/core/SkDraw.cpp File src/core/SkDraw.cpp (right): https://codereview.chromium.org/270023002/diff/1/src/core/SkDraw.cpp#newcode2436 src/core/SkDraw.cpp:2436: const int alphaScale = alpha + (alpha >> ...
6 years, 7 months ago (2014-05-05 21:15:02 UTC) #2
reed1
https://codereview.chromium.org/270023002/diff/1/src/core/SkDraw.cpp File src/core/SkDraw.cpp (right): https://codereview.chromium.org/270023002/diff/1/src/core/SkDraw.cpp#newcode2436 src/core/SkDraw.cpp:2436: const int alphaScale = alpha + (alpha >> 7); ...
6 years, 7 months ago (2014-05-05 21:25:14 UTC) #3
scroggo
lgtm
6 years, 7 months ago (2014-05-05 21:27:19 UTC) #4
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-05 21:28:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/270023002/20001
6 years, 7 months ago (2014-05-05 21:28:21 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 21:35:20 UTC) #7
Message was sent while issue was closed.
Change committed as 14581

Powered by Google App Engine
This is Rietveld 408576698