Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2700143002: [turbofan] Don't report failed map check as failed instance migration. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't report failed map check as failed instance migration. Failed instance migration should only be reported if the map of the object was originally marked as deprecated. Otherwise it's pretty confusing to investigate deoptimizations. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2700143002 Cr-Commit-Position: refs/heads/master@{#43293} Committed: https://chromium.googlesource.com/v8/v8/+/00a379a03e31bf6eb87cd53212fde8aa1d3c1f67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M src/compiler/effect-control-linearizer.cc View 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-17 13:16:50 UTC) #1
Jarin
lgtm
3 years, 10 months ago (2017-02-17 14:11:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700143002/1
3 years, 10 months ago (2017-02-17 19:13:11 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 19:15:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/00a379a03e31bf6eb87cd53212fde8aa1d3...

Powered by Google App Engine
This is Rietveld 408576698