|
Revert 268246 "Revert 268232 "Refactor MetricsStateManager class..."
r268232 was erroneously blamed, so re-applying it.
> Revert 268232 "Refactor MetricsStateManager class out of Metrics..."
>
> Failed 'sizes' check: chrome-si (static initializers) incremented.
>
> > Refactor MetricsStateManager class out of MetricsService.
> >
> > The new class is responsible for managing various MetricsService state prefs,
> > such as client id, low entropy source and the UMA opt-in state, as well as the
> > cloned install detector.
> >
> > Also, moves IsMetricsReportingEnabled() from chrome_browser_main.cc to
> > the new class as well as changing a couple MetricsService browser tests
> > to instead be unit tests of the new class.
> >
> > BUG= 368413
> >
> > Review URL: https://codereview.chromium.org/256143006
>
> TBR=asvitkine@chromium.org
>
> Review URL: https://codereview.chromium.org/268223002
TBR=miu@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268264
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+76 lines, -442 lines) |
Patch |
 |
M |
trunk/src/chrome/browser/chrome_browser_main.h
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chrome_browser_main.cc
|
View
|
|
4 chunks |
+10 lines, -41 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/metrics/cloned_install_detector_unittest.cc
|
View
|
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/metrics/metrics_service.h
|
View
|
|
11 chunks |
+20 lines, -72 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/metrics/metrics_service.cc
|
View
|
|
17 chunks |
+31 lines, -175 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/metrics/metrics_service_browsertest.cc
|
View
|
|
4 chunks |
+2 lines, -26 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/metrics/metrics_service_unittest.cc
|
View
|
|
6 chunks |
+11 lines, -121 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/metrics/metrics_state_manager.h
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/metrics/metrics_state_manager.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
A + |
trunk/src/chrome/browser/metrics/metrics_state_manager_unittest.cc
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/prefs/browser_prefs.cc
|
View
|
|
3 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_browser.gypi
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_tests_unit.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|