|
Revert 268232 "Refactor MetricsStateManager class out of Metrics..."
Failed 'sizes' check: chrome-si (static initializers) incremented.
> Refactor MetricsStateManager class out of MetricsService.
>
> The new class is responsible for managing various MetricsService state prefs,
> such as client id, low entropy source and the UMA opt-in state, as well as the
> cloned install detector.
>
> Also, moves IsMetricsReportingEnabled() from chrome_browser_main.cc to
> the new class as well as changing a couple MetricsService browser tests
> to instead be unit tests of the new class.
>
> BUG= 368413
>
> Review URL: https://codereview.chromium.org/256143006
TBR=asvitkine@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268246
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+445 lines, -596 lines) |
Patch |
 |
M |
trunk/src/chrome/browser/chrome_browser_main.h
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/chrome_browser_main.cc
|
View
|
|
4 chunks |
+41 lines, -10 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/metrics/cloned_install_detector_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/metrics/metrics_service.h
|
View
|
|
11 chunks |
+72 lines, -20 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/metrics/metrics_service.cc
|
View
|
|
17 chunks |
+175 lines, -31 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/metrics/metrics_service_browsertest.cc
|
View
|
|
4 chunks |
+26 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/metrics/metrics_service_unittest.cc
|
View
|
|
6 chunks |
+121 lines, -11 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/metrics/metrics_state_manager.h
|
View
|
|
1 chunk |
+0 lines, -124 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/metrics/metrics_state_manager.cc
|
View
|
|
1 chunk |
+0 lines, -233 lines |
0 comments
|
Download
|
 |
D |
trunk/src/chrome/browser/metrics/metrics_state_manager_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -160 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/browser/prefs/browser_prefs.cc
|
View
|
|
3 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_browser.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
trunk/src/chrome/chrome_tests_unit.gypi
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|