Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2700113004: MD-Settings: Don't show advanced settings in guest mode (Closed)

Created:
3 years, 10 months ago by hcarmona
Modified:
3 years, 10 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD-Settings: Don't show advanced settings in guest mode R=dschuyler@chromium.org BUG=693398 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2700113004 Cr-Commit-Position: refs/heads/master@{#452345} Committed: https://chromium.googlesource.com/chromium/src/+/0d7e814d475cbb9804ba706eac482fea6ff1980b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
hcarmona
PTAL
3 years, 10 months ago (2017-02-17 18:25:53 UTC) #6
dschuyler
lgtm Thanks for looking into the page visibility and for following up on that in ...
3 years, 10 months ago (2017-02-22 23:55:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700113004/1
3 years, 10 months ago (2017-02-23 00:09:44 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 02:04:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0d7e814d475cbb9804ba706eac48...

Powered by Google App Engine
This is Rietveld 408576698