[csa] SubString should enforce Stringness of first parameter.

[csa] SubString should enforce Stringness of first parameter.

The CodeStubAssembler::SubString method should not try to be defensive
about non-string inputs, but really enforce String receiver. Passing
a non-String input will result in crash in the %SubString runtime
function anyway.

R=jgruber@chromium.org

Review-Url: https://codereview.chromium.org/2700103002
Cr-Commit-Position: refs/heads/master@{#43267}
Committed: https://chromium.googlesource.com/v8/v8/+/4a7436101da9ab09ff5b543f64839e05feb365d0

[Benedikt Meurer, 2017-02-17 07:56:35]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 07:56:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-02-17 08:00:25]

lgtm

[Benedikt Meurer, 2017-02-17 08:00:29]

The CQ bit was unchecked by bmeurer@chromium.org

[Benedikt Meurer, 2017-02-17 08:00:32]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-02-17 08:00:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 08:27:01]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487318432973520, "parent_rev":
"e1f7ae3328b7c23249e61dfa409237976f8811ea", "commit_rev":
"4a7436101da9ab09ff5b543f64839e05feb365d0"}

[commit-bot: I haz the power, 2017-02-17 08:27:06]

Description was changed from

==========
[csa] SubString should enforce Stringness of first parameter.

The CodeStubAssembler::SubString method should not try to be defensive
about non-string inputs, but really enforce String receiver. Passing
a non-String input will result in crash in the %SubString runtime
function anyway.

R=jgruber@chromium.org
==========

to

==========
[csa] SubString should enforce Stringness of first parameter.

The CodeStubAssembler::SubString method should not try to be defensive
about non-string inputs, but really enforce String receiver. Passing
a non-String input will result in crash in the %SubString runtime
function anyway.

R=jgruber@chromium.org

Review-Url: https://codereview.chromium.org/2700103002
Cr-Commit-Position: refs/heads/master@{#43267}
Committed:
https://chromium.googlesource.com/v8/v8/+/4a7436101da9ab09ff5b543f64839e05feb...
==========

[commit-bot: I haz the power, 2017-02-17 08:27:07]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4a7436101da9ab09ff5b543f64839e05feb...