Views/Harmony: Use LayoutDelegate::GetMetric() for views::kPanelHorizMargin.

Views/Harmony: Use LayoutDelegate::GetMetric() for views::kPanelHorizMargin.

Replace direct references to views::kPanelHorizMargin under chrome/* with a call
to LayoutDelegate::GetMetric().

BUG=691897
Review-Url: https://codereview.chromium.org/2700083002
Cr-Commit-Position: refs/heads/master@{#452376}
Committed: https://chromium.googlesource.com/chromium/src/+/cf729d6b29b5ff36ef3115f88b45193c59ab3f52

[Patti Lor, 2017-02-17 06:24:07]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 06:24:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 06:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 06:44:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-02-19 23:08:38]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-19 23:08:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-19 23:57:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-19 23:57:06]

Dry run: This issue passed the CQ dry run.

[Patti Lor, 2017-02-20 01:37:26]

patricialor@chromium.org changed reviewers:
+ tapted@chromium.org

[Patti Lor, 2017-02-20 01:37:27]

Hi Trent, PTAL - I've missed bubble_dialog_delegate.cc & views_delegate.cc, but
I think that is intended (for now) until https://crbug.com/687349 is fixed.

[tapted, 2017-02-20 04:42:00]

lgtm % nit

https://codereview.chromium.org/2700083002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc (right):

https://codereview.chromium.org/2700083002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc:34: const int
kBorderHorizMargin = LayoutDelegate::Get()->GetMetric(
nit: const int border_horiz_margin = ..

(we only use kFooStyle for compile-time constants - e.g. when `constexpr int
kFoo..` would work)

[Patti Lor, 2017-02-20 04:55:30]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 04:55:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-20 06:09:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 06:09:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Patti Lor, 2017-02-20 06:15:36]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-20 06:15:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Patti Lor, 2017-02-20 06:34:38]

patricialor@chromium.org changed reviewers:
+ pkasting@chromium.org

[Patti Lor, 2017-02-20 06:34:39]

Hi pkasting, PTAL for owner's review on all files. Thank you!

https://codereview.chromium.org/2700083002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc (right):

https://codereview.chromium.org/2700083002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc:34: const int
kBorderHorizMargin = LayoutDelegate::Get()->GetMetric(
On 2017/02/20 04:42:00, tapted wrote:
> nit: const int border_horiz_margin = ..
> 
> (we only use kFooStyle for compile-time constants - e.g. when `constexpr int
> kFoo..` would work)

Done, thanks!

[commit-bot: I haz the power, 2017-02-20 06:45:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-20 06:45:32]

Dry run: This issue passed the CQ dry run.

[Patti Lor, 2017-02-21 22:43:23]

On 2017/02/20 06:34:39, Patti Lor wrote:
> Hi pkasting, PTAL for owner's review on all files. Thank you!
> 
>
https://codereview.chromium.org/2700083002/diff/20001/chrome/browser/ui/views...
> File chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc
(right):
> 
>
https://codereview.chromium.org/2700083002/diff/20001/chrome/browser/ui/views...
> chrome/browser/ui/views/extensions/media_gallery_checkbox_view.cc:34: const
int
> kBorderHorizMargin = LayoutDelegate::Get()->GetMetric(
> On 2017/02/20 04:42:00, tapted wrote:
> > nit: const int border_horiz_margin = ..
> > 
> > (we only use kFooStyle for compile-time constants - e.g. when `constexpr int
> > kFoo..` would work)
> 
> Done, thanks!

pkasting@ - ping in case you haven't seen this yet :)

[Peter Kasting, 2017-02-21 22:59:50]

LGTM

I did see it, I was just out yesterday and hadn't made it to code reviews today.
 Thanks for the ping, it prompted me to do this sooner rather than later :)

[Peter Kasting, 2017-02-21 23:01:49]

(By the way, you can also replace kPanelVertMargin with this constant if you see
that in use.  There's one or two other similar pairs of constants like this
already as well; basically, if pre-Harmony uses a "horiz" or "vert" constant to
define something that the layout delegate does not explicitly call "horiz" or
"vert" in the enum name, it's a case like this.)

[Patti Lor, 2017-02-21 23:25:26]

On 2017/02/21 23:01:49, Peter Kasting wrote:
> (By the way, you can also replace kPanelVertMargin with this constant if you
see
> that in use.  There's one or two other similar pairs of constants like this
> already as well; basically, if pre-Harmony uses a "horiz" or "vert" constant
to
> define something that the layout delegate does not explicitly call "horiz" or
> "vert" in the enum name, it's a case like this.)

Oh, thanks for the FYI, will start replacing all of them in future CLs. Thanks
for your review!

[Patti Lor, 2017-02-21 23:25:34]

The CQ bit was checked by patricialor@chromium.org

[Patti Lor, 2017-02-21 23:25:34]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2700083002/#ps40001
(title: "Review comments.")

[commit-bot: I haz the power, 2017-02-21 23:27:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 01:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 01:35:44]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[Patti Lor, 2017-02-23 02:16:39]

The CQ bit was checked by patricialor@chromium.org

[commit-bot: I haz the power, 2017-02-23 02:17:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 03:30:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487816199984400,
"parent_rev": "6837d7983dd1c0c113761fb4058b6cf0895fdd9c", "commit_rev":
"cf729d6b29b5ff36ef3115f88b45193c59ab3f52"}

[commit-bot: I haz the power, 2017-02-23 03:30:56]

Description was changed from

==========
Views/Harmony: Use LayoutDelegate::GetMetric() for views::kPanelHorizMargin.

Replace direct references to views::kPanelHorizMargin under chrome/* with a call
to LayoutDelegate::GetMetric().

BUG=691897
==========

to

==========
Views/Harmony: Use LayoutDelegate::GetMetric() for views::kPanelHorizMargin.

Replace direct references to views::kPanelHorizMargin under chrome/* with a call
to LayoutDelegate::GetMetric().

BUG=691897

Review-Url: https://codereview.chromium.org/2700083002
Cr-Commit-Position: refs/heads/master@{#452376}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf729d6b29b5ff36ef3115f88b45...
==========

[commit-bot: I haz the power, 2017-02-23 03:30:57]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cf729d6b29b5ff36ef3115f88b45...