Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2700073003: Take the rotation information from the right source. (Closed)

Created:
3 years, 10 months ago by yamaguchi
Modified:
3 years, 10 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Take the rotation information from the right source. The transform data may be stored in thumbnail instead of media. The constructor of ThumbnailLoader has the logic to detect the both. This is a follow-up of 2691933007. BUG=680420 TEST=browser_tests --gtest_filter=FileManagerJsTest.ThumbnailLoader CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2700073003 Cr-Commit-Position: refs/heads/master@{#451559} Committed: https://chromium.googlesource.com/chromium/src/+/17312b794d9fa968a6cb09e2cf4eb0e9ecf743df

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/file_manager/file_manager/foreground/js/thumbnail_loader.js View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/thumbnail_loader_unittest.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
yamaguchi
PTAL
3 years, 10 months ago (2017-02-20 04:07:34 UTC) #9
mtomasz
lgtm
3 years, 10 months ago (2017-02-20 04:09:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700073003/1
3 years, 10 months ago (2017-02-20 04:15:20 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 05:19:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17312b794d9fa968a6cb09e2cf4e...

Powered by Google App Engine
This is Rietveld 408576698