Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2700073002: core/loader: create private directory to store private classes (Closed)

Created:
3 years, 10 months ago by Takashi Toyoshima
Modified:
3 years, 10 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, Yoav Weiss, gavinp+prerender_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

core/loader: create private directory to store private classes To store classes that should not be used outside core/loader, create private directory and store such files under the directory. This is not a well-known convention in chromium or blink, and does not enforce it unlike DEPS rule. BUG=692998 Review-Url: https://codereview.chromium.org/2700073002 Cr-Commit-Position: refs/heads/master@{#451577} Committed: https://chromium.googlesource.com/chromium/src/+/2141637b7eff02a6f694848826463bcb7bf63a91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -573 lines) Patch
M third_party/WebKit/Source/core/loader/BUILD.gn View 4 chunks +6 lines, -5 lines 0 comments Download
D third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.h View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp View 1 chunk +0 lines, -210 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/loader/FrameClientHintsPreferencesContext.h View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/Source/core/loader/FrameClientHintsPreferencesContext.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HttpEquiv.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/loader/PrerenderHandle.h View 1 chunk +0 lines, -78 lines 0 comments Download
D third_party/WebKit/Source/core/loader/PrerenderHandle.cpp View 1 chunk +0 lines, -113 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/private/CrossOriginPreflightResultCache.h View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/private/CrossOriginPreflightResultCache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/private/FrameClientHintsPreferencesContext.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/private/FrameClientHintsPreferencesContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/core/loader/private/PrerenderHandle.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/core/loader/private/PrerenderHandle.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Takashi Toyoshima
PTAL
3 years, 10 months ago (2017-02-17 09:51:17 UTC) #3
yhirano
lgtm
3 years, 10 months ago (2017-02-20 05:48:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700073002/1
3 years, 10 months ago (2017-02-20 05:56:49 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 07:44:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2141637b7eff02a6f69484882646...

Powered by Google App Engine
This is Rietveld 408576698