Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/js_emitter/class_stub_generator.dart

Issue 2700053003: Don't use magic strings/properties to communicate between compiler and runtime. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart » ('j') | sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/class_stub_generator.dart
diff --git a/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart b/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart
index 56ef69ee3adaa819b0dd0ba79baf057d9c6bae04..05019645d918d30cb86c76eb9dae4f959dcf2322 100644
--- a/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart
+++ b/pkg/compiler/lib/src/js_emitter/class_stub_generator.dart
@@ -40,9 +40,9 @@ class ClassStubGenerator {
var typeParameters = const <jsAst.Parameter>[];
var typeInits = const <jsAst.Expression>[];
if (hasRtiField) {
- String parameterName = r'$ti';
+ String parameterName = namer.rtiName;
typeParameters = parameterName;
- typeInits = js('this.# = #', [namer.rtiFieldName, parameterName]);
+ typeInits = js('this.# = #', [namer.rtiFieldJsName, parameterName]);
sra1 2017/02/22 04:23:52 This is the place I was telling you about. See htt
floitsch 2017/02/22 12:58:06 Done.
}
return js('function(#, #) { #; #; this.#();}', [
fields,
« no previous file with comments | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart » ('j') | sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698