Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: pkg/compiler/lib/src/js_backend/namer.dart

Issue 2700053003: Don't use magic strings/properties to communicate between compiler and runtime. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/namer.dart
diff --git a/pkg/compiler/lib/src/js_backend/namer.dart b/pkg/compiler/lib/src/js_backend/namer.dart
index bc9a88045acc18dc73298010dbec79f6d3138afb..4ec790677d19f1db654b8ceb70ec9a516d63ded3 100644
--- a/pkg/compiler/lib/src/js_backend/namer.dart
+++ b/pkg/compiler/lib/src/js_backend/namer.dart
@@ -475,8 +475,11 @@ class Namer {
jsAst.Name get staticsPropertyName =>
_staticsPropertyName ??= new StringBackedName('static');
- jsAst.Name _rtiFieldName;
- jsAst.Name get rtiFieldName => _rtiFieldName ??= new StringBackedName(r'$ti');
+ final String rtiName = r'$ti';
+
+ jsAst.Name _rtiFieldJsName;
+ jsAst.Name get rtiFieldJsName =>
+ _rtiFieldJsName ??= new StringBackedName(rtiName);
// Name of property in a class description for the native dispatch metadata.
final String nativeSpecProperty = '%';
@@ -620,8 +623,12 @@ class Namer {
return asName(operatorAsPrefix);
case JsGetName.SIGNATURE_NAME:
return asName(operatorSignature);
+ case JsGetName.RTI_NAME:
+ return asName(rtiName);
case JsGetName.TYPEDEF_TAG:
return asName(typedefTag);
+ case JsGetName.FUNCTION_TYPE_TAG:
+ return asName(functionTypeTag);
case JsGetName.FUNCTION_TYPE_VOID_RETURN_TAG:
return asName(functionTypeVoidReturnTag);
case JsGetName.FUNCTION_TYPE_RETURN_TYPE_TAG:

Powered by Google App Engine
This is Rietveld 408576698