Remove HeapProfiler.finishHeapSnapshot event from remote debugging protocol

Source/devtools/front_end/HeapSnapshotView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 743 matching lines @@
      * @param {number} uid
      * @param {string} chunk
      */
     addHeapSnapshotChunk: function(uid, chunk)
     {
         this._genericCaller("addHeapSnapshotChunk");
     },
 
     /**
      * @override
-     * @param {number} uid
-     */
-    finishHeapSnapshot: function(uid)
-    {
-        this._genericCaller("finishHeapSnapshot");
-    },
-
-    /**
-     * @override
      * @param {number} done
      * @param {number} total
      */
     reportHeapSnapshotProgress: function(done, total)
     {
         this._genericCaller("reportHeapSnapshotProgress");
     },
 
     /**
      * @override
@@ skipping 131 matching lines @@
      */
     addHeapSnapshotChunk: function(uid, chunk)
     {
         var profile = this._profilesIdMap[this._makeKey(uid)];
         if (profile)
             profile.transferChunk(chunk);
     },
 
     /**
      * @override
-     * @param {number} uid
-     */
-    finishHeapSnapshot: function(uid)
-    {
-        var profile = this._profilesIdMap[this._makeKey(uid)];
-        if (profile)
-            profile.finishHeapSnapshot();
-    },
-
-    /**
-     * @override
      * @param {number} done
      * @param {number} total
      */
     reportHeapSnapshotProgress: function(done, total)
     {
         var profile = this.findTemporaryProfile();
         if (profile)
             this.dispatchEventToListeners(WebInspector.ProfileType.Events.ProgressUpdated, {"profile": profile, "done": done, "total": total});
     },
 
@@ skipping 242 matching lines @@
             callback(this._snapshotProxy);
             return;
         }
 
         this._numberOfChunks = 0;
         if (!this._receiver) {
             this._setupWorker();
             this._transferHandler = new WebInspector.BackendSnapshotLoader(this);
             this.sidebarElement.subtitle = WebInspector.UIString("Loading\u2026");
             this.sidebarElement.wait = true;
-            this.startSnapshotTransfer();
+            this._transferSnapshot();
         }
         var loaderProxy = /** @type {WebInspector.HeapSnapshotLoaderProxy} */ (this._receiver);
         loaderProxy.addConsumer(callback);
     },
 
-    startSnapshotTransfer: function()
+    _transferSnapshot: function()
     {
-        HeapProfilerAgent.getHeapSnapshot(this.uid);
+        function finishTransfer()
+        {
+            if (this._transferHandler) {
+                this._transferHandler.finishTransfer();
+                this._totalNumberOfChunks = this._transferHandler._totalNumberOfChunks;
+            }
+        }
+        HeapProfilerAgent.getHeapSnapshot(this.uid, finishTransfer.bind(this));
     },
 
     snapshotConstructorName: function()
     {
         return "JSHeapSnapshot";
     },
 
     snapshotProxyConstructor: function()
     {
         return WebInspector.HeapSnapshotProxy;
@@ skipping 76 matching lines @@
             }
             snapshotProxy.maxJsNodeId(didGetMaxNodeId.bind(this));
         }
     },
 
     notifySnapshotReceived: function()
     {
         this._profileType._snapshotReceived(this);
     },
 
-    finishHeapSnapshot: function()
-    {
-        if (this._transferHandler) {
-            this._transferHandler.finishTransfer();
-            this._totalNumberOfChunks = this._transferHandler._totalNumberOfChunks;
-        }
-    },
-
     // Hook point for tests.
     _wasShown: function()
     {
     },
 
     /**
      * @override
      * @return {boolean}
      */
     canSaveToFile: function()
     {
         return !this.fromFile() && !!this._snapshotProxy && !this._receiver;
     },
 
     /**
      * @override
      */
     saveToFile: function()
     {
         var fileOutputStream = new WebInspector.FileOutputStream();
         function onOpen()
         {
             this._receiver = fileOutputStream;
             this._transferHandler = new WebInspector.SaveSnapshotHandler(this);
-            HeapProfilerAgent.getHeapSnapshot(this.uid);
+            this._transferSnapshot();
         }
         this._fileName = this._fileName || "Heap-" + new Date().toISO8601Compact() + this._profileType.fileExtension();
         fileOutputStream.open(this._fileName, onOpen.bind(this));
     },
 
     /**
      * @override
      * @param {File} file
      */
     loadFromFile: function(file)
@@ skipping 483 matching lines @@
     zeroTime: function()
     {
         return this._minimumBoundaries;
     },
 
     boundarySpan: function()
     {
         return this._maximumBoundaries - this._minimumBoundaries;
     }
 }